refactor(github workflows): replace env variables with secrets for ap…

…p-id and private-key to enhance security remove(env): delete APP_ID and PRIVATE_KEY from main.yml as they are no longer needed after refactor
nkdAgility · Jul 17, 2024 · 104ed1e · 104ed1e
1 parent 0456fb5
commit 104ed1e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/code-review.yml b/.github/workflows/code-review.yml
@@ -15,8 +15,8 @@ jobs:
       - uses: actions/create-github-app-token@v1
         id: app-token
         with:
-          app-id: ${{ env.APP_ID }}
-          private-key: ${{ env.PRIVATE_KEY }}
+          app-id: ${{ secrets.NKDAGILITY_BOT_APP_ID }}
+          private-key: ${{ secrets.NKDAGILITY_BOT_CLIENTSECRET }}
       - uses: fitomad/github-chatgpt-integration@main
         with:
           openai-api-key: ${{ secrets.OPENAI_API_KEY }}

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -21,10 +21,6 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-env:
-   APP_ID: "Iv23li9aYvt0VW9x4Jhh"
-   PRIVATE_KEY: ${{ secrets.NKDAGILITY_BOT_CLIENTSECRET }}
-
 defaults:
   run:
     shell: pwsh
@@ -264,8 +260,8 @@ jobs:
       - uses: actions/create-github-app-token@v1
         id: app-token
         with:
-          app-id: ${{ env.APP_ID }}
-          private-key: ${{ env.PRIVATE_KEY }}
+          app-id: ${{ secrets.NKDAGILITY_BOT_APP_ID }}
+          private-key: ${{ secrets.NKDAGILITY_BOT_CLIENTSECRET }}
       - name: "Package  Files"
         shell: pwsh
         run: |