Skip to content

Commit

Permalink
🔧 (main.yml): update workflow conditions to ensure steps run only on …
Browse files Browse the repository at this point in the history
…successful setup and relevant changes

Add success() condition to the build and BuildDocs jobs to ensure they only run if the Setup job is successful. This prevents unnecessary executions and potential errors. Also, refine the condition for the deploy job to ensure it runs only if there are changes in the source code and the setup is successful, excluding the 'Canary' ring.
  • Loading branch information
MrHinsh committed Aug 8, 2024
1 parent 1317230 commit 20e6a24
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,12 @@ jobs:
echo $markdown >> $Env:GITHUB_STEP_SUMMARY
# Build, Test, Sonar Cloud Analysis, & Package

build:
name: "Build, Test, Sonar Cloud Analysis, & Package"
runs-on: windows-latest
needs: Setup
if: ${{ needs.Setup.outputs.HasChanged_src }}
if: ${{ success() && ( needs.Setup.outputs.HasChanged_src ) }}
env:
solution: '**/*.sln'
buildPlatform: 'Any CPU'
Expand Down Expand Up @@ -220,6 +221,7 @@ jobs:
BuildDocs:
name: "Build Documentation output"
runs-on: ubuntu-latest
if: ${{ success() && ( needs.Setup.outputs.HasChanged_docs ) }}
needs: [Setup]
env:
GitVersion_SemVer: ${{ needs.Setup.outputs.GitVersion_SemVer }}
Expand Down Expand Up @@ -258,7 +260,7 @@ jobs:
HasChanged_docs: ${{ needs.Setup.outputs.HasChanged_docs }}
HasChanged_automation: ${{ needs.Setup.outputs.HasChanged_automation }}
needs: [build, Setup]
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) }}
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && ( needs.Setup.outputs.HasChanged_src ) }}
steps:
- uses: actions/download-artifact@v4
with:
Expand Down

0 comments on commit 20e6a24

Please sign in to comment.