Skip to content

Commit

Permalink
🔧 (main.yml): update conditional checks to compare against 'true' string
Browse files Browse the repository at this point in the history
The conditional checks in the GitHub Actions workflow are updated to compare against the string 'true' instead of a boolean. This ensures that the conditions are evaluated correctly, as the outputs from the Setup job are strings.
  • Loading branch information
MrHinsh committed Aug 8, 2024
1 parent 86d272d commit 2dea201
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
name: "Build, Test, Sonar Cloud Analysis, & Package"
runs-on: windows-latest
needs: Setup
if: ${{ success() && ( needs.Setup.outputs.HasChanged_src ) }}
if: ${{ success() && ( needs.Setup.outputs.HasChanged_src == 'true' ) }}
env:
solution: '**/*.sln'
buildPlatform: 'Any CPU'
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
BuildDocs:
name: "Build Documentation output"
runs-on: ubuntu-latest
if: ${{ success() && ( needs.Setup.outputs.HasChanged_docs ) }}
if: ${{ success() && ( needs.Setup.outputs.HasChanged_docs == 'true' ) }}
needs: [Setup]
env:
GitVersion_SemVer: ${{ needs.Setup.outputs.GitVersion_SemVer }}
Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
HasChanged_docs: ${{ needs.Setup.outputs.HasChanged_docs }}
HasChanged_automation: ${{ needs.Setup.outputs.HasChanged_automation }}
needs: [build, Setup]
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && ( needs.Setup.outputs.HasChanged_src ) }}
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && ( needs.Setup.outputs.HasChanged_src == 'true' ) }}
steps:
- uses: actions/download-artifact@v4
with:
Expand Down Expand Up @@ -360,7 +360,7 @@ jobs:
name: "Release to Chocolatey"
runs-on: windows-latest
needs: [Setup, GitHubRelease]
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && (needs.Setup.outputs.HasChanged_src) }}
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && (needs.Setup.outputs.HasChanged_src == 'true') }}
steps:
- uses: actions/download-artifact@v4
with:
Expand All @@ -384,7 +384,7 @@ jobs:
name: "Release to Winget"
runs-on: windows-latest
needs: [Setup, GitHubRelease]
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && (needs.Setup.outputs.HasChanged_src) }}
if: ${{ success() && ( needs.Setup.outputs.nkdAgility_Ring != 'Canary' ) && (needs.Setup.outputs.HasChanged_src == 'true') }}
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down

0 comments on commit 2dea201

Please sign in to comment.