Removing some Error meesages that are user based #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: refactor telemetry handling and improve logging configuration Refactor the telemetry handling to allow disabling telemetry via settings. This change introduces a new `IServiceProvider` dependency to `CommandBase` and `ExecuteMigrationCommand` to access `TelemetryConfiguration`. The telemetry note now reflects whether telemetry is disabled based on user settings. Additionally, improve logging configuration by commenting out unnecessary exclusions to ensure comprehensive logging. This refactor enhances flexibility and transparency in telemetry and logging.
…failure The log message is updated to provide more context, indicating that the folder should be cleaned up at the end. This helps in understanding the impact of the failure and sets the expectation for future cleanup. The telemetry tracking of the exception is removed, possibly to reduce noise in the telemetry data or because it is deemed unnecessary for this specific case.
Corrects a typo in the log message from "cleanned" to "cleaned" to improve readability and professionalism in the codebase.
♻️ (MigrationToolHost): refine logging configuration and error handling ♻️ (StartupService): improve logging and error tracking Update the documentation to reflect the latest branch and commit details. Refactor the logging configuration in `MigrationToolHost.cs` to exclude specific sources and improve error handling by using `Environment.Exit(-1)` for missing config files. Enhance `StartupService.cs` by removing redundant log messages, adding error logging for application exit codes, and tracking unhandled exceptions with telemetry. These changes improve code readability, maintainability, and error tracking.
The change replaces the `InvalidOperationException` with a critical log message and an immediate exit using `Environment.Exit(-1)`. This ensures that the application logs the error more clearly and terminates gracefully, providing better feedback and control over the application's behavior in case of a critical failure.
…all in exception handling The Telemetry.TrackException call is removed because it is redundant and does not provide additional value in this context. The exception is already logged with Log.LogDebug, which is sufficient for debugging purposes.
github-actions
bot
added
enhancement
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should remove some common user errors from the logging.