Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hosts (again) and Reconcile Project & Solution referecnces. #2225

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

MrHinsh
Copy link
Member

@MrHinsh MrHinsh commented Jul 29, 2024

♻️ (solution): remove NKDAgility.AzureDevOps.Tools.CommandHost project and update project references

🔧 (docs): update generated XML documentation to reflect latest commit and branch information

The NKDAgility.AzureDevOps.Tools.CommandHost project is removed from the solution to streamline the project structure. This change also updates the project references to point to the correct paths, ensuring that the solution builds correctly. The generated XML documentation is updated to reflect the latest commit and branch information, ensuring that the documentation is accurate and up-to-date.

♻️ (refactor): update project references and remove unused code

  • Update project references to use MigrationTools.Helpers.Tests instead of MigrationTools.Fakes.
  • Rename NKDAgility.AzureDevOps.Tools.CommandHost project to MigrationTools.Helpers.Tests.
  • Add new fake classes FakeMigrationToolVersion and FakeMigrationToolVersionInfo for testing.
  • Replace RunMigrationTools with RunConsoleAsync in Program.cs files.
  • Remove unused HostExtensions and MigrationService classes.

These changes improve the project structure by consolidating test helpers into a single project, ensuring consistency in project references, and removing obsolete code. This refactor enhances maintainability and clarity in the codebase.

♻️ (MigrationTools.Host): refactor to use Spectre.Console.Extensions.Hosting and remove redundant services
🔧 (MigrationTools.Host): update project references to reflect new structure

Refactor the code to use Spectre.Console.Extensions.Hosting instead of Spectre.Console.Cli.Extensions.DependencyInjection for better integration and maintainability. Remove redundant services like StartupService and DetectVersionService to simplify the codebase. Update project references to reflect the new structure, ensuring that tests and other dependencies are correctly aligned with the changes. This improves the overall architecture and reduces complexity.

♻️ (tests): update namespace and project references from MigrationTools.Fakes to MigrationTools.Helpers.Tests

The namespace and project references are updated to reflect the new location and naming convention for the test helpers. This change improves code organization and clarity by using a more descriptive and accurate namespace.

…t and update project references

🔧 (docs): update generated XML documentation to reflect latest commit and branch information

The NKDAgility.AzureDevOps.Tools.CommandHost project is removed from the solution to streamline the project structure. This change also updates the project references to point to the correct paths, ensuring that the solution builds correctly. The generated XML documentation is updated to reflect the latest commit and branch information, ensuring that the documentation is accurate and up-to-date.

♻️ (refactor): update project references and remove unused code

- Update project references to use `MigrationTools.Helpers.Tests` instead of `MigrationTools.Fakes`.
- Rename `NKDAgility.AzureDevOps.Tools.CommandHost` project to `MigrationTools.Helpers.Tests`.
- Add new fake classes `FakeMigrationToolVersion` and `FakeMigrationToolVersionInfo` for testing.
- Replace `RunMigrationTools` with `RunConsoleAsync` in `Program.cs` files.
- Remove unused `HostExtensions` and `MigrationService` classes.

These changes improve the project structure by consolidating test helpers into a single project, ensuring consistency in project references, and removing obsolete code. This refactor enhances maintainability and clarity in the codebase.

♻️ (MigrationTools.Host): refactor to use Spectre.Console.Extensions.Hosting and remove redundant services
🔧 (MigrationTools.Host): update project references to reflect new structure

Refactor the code to use `Spectre.Console.Extensions.Hosting` instead of `Spectre.Console.Cli.Extensions.DependencyInjection` for better integration and maintainability. Remove redundant services like `StartupService` and `DetectVersionService` to simplify the codebase. Update project references to reflect the new structure, ensuring that tests and other dependencies are correctly aligned with the changes. This improves the overall architecture and reduces complexity.

♻️ (tests): update namespace and project references from MigrationTools.Fakes to MigrationTools.Helpers.Tests

The namespace and project references are updated to reflect the new location and naming convention for the test helpers. This change improves code organization and clarity by using a more descriptive and accurate namespace.
@MrHinsh MrHinsh self-assigned this Jul 29, 2024
…ndBase, ExecuteMigrationCommand, MigrationToolHost): refactor error handling and telemetry configuration

- Update log messages to provide more context and clarity.
- Remove telemetry tracking for specific exceptions to reduce noise.
- Replace exceptions with critical log messages and exit the application for better control flow.
- Add support for disabling telemetry via settings in CommandBase.
- Refactor logging configuration to exclude specific Microsoft sources for cleaner logs.

These changes improve error handling by providing more informative log messages and better control over application flow. Disabling telemetry based on user settings enhances privacy and control for users. The logging configuration changes help in maintaining cleaner and more relevant logs.
@MrHinsh MrHinsh marked this pull request as ready for review July 29, 2024 14:35
@MrHinsh MrHinsh enabled auto-merge July 29, 2024 14:35
@MrHinsh MrHinsh merged commit 859423f into main Jul 29, 2024
11 checks passed
@MrHinsh MrHinsh deleted the bug/some-merging-issues-resolved branch July 29, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant