-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontload Docs Setup #2282
Merged
Merged
Frontload Docs Setup #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add steps to set `docs_version_folder` and `docs_deploy_folder` variables for documentation deployment. This ensures that the documentation is deployed to the correct folder based on the version and ring environment. This change improves the automation process by dynamically setting the deployment paths, making the workflow more adaptable to different environments and versions.
…tion paths Remove unused `IsBuildEditBranch` output and add new outputs for `docs_deploy_folder` and `docs_version_folder`. This change ensures that the documentation paths are correctly set up based on the release ring and version, improving the deployment process for documentation.
…lder-Decision step Change absolute paths to relative paths for docs_deploy_folder to ensure compatibility across different environments. Remove the redundant Folder-Decision step to streamline the workflow and avoid unnecessary complexity. This improves the maintainability and readability of the workflow configuration.
Update the conditions in the GitHub Actions workflow to allow jobs to run for 'Preview' and 'Release' rings. This change ensures that jobs are executed not only when the ring is 'Release' but also when it is 'Preview' and the source has changed. This improves the flexibility and control over the deployment process, allowing for more granular release management.
…nstead of '=' The conditional checks for `nkdAgility_Ring` in the GitHub Actions workflow are corrected to use `==` for comparison instead of `=`. This ensures proper evaluation of the conditions, allowing the workflow to execute correctly based on the ring type.
Corrects the conditional expressions in the GitHub Actions workflow by changing assignment operators (`=`) to equality operators (`==`). This ensures the conditions are evaluated correctly, preventing unintended behavior during workflow execution.
Corrects the conditional expression in the GitHub Actions workflow to ensure proper evaluation. The previous expression had a single equals sign (`=`) instead of a double equals sign (`==`) for comparison, which could lead to incorrect job execution.
Introduce a new `RunRelease` output to streamline the release process. This change ensures that the release steps are only executed when necessary, based on the `RunRelease` flag. This improves the workflow by making it more efficient and reducing unnecessary steps, especially for non-release branches.
Remove an extra parenthesis in the conditional statement to ensure the workflow runs correctly. The previous syntax error could prevent the "Release to Marketplace" job from executing as intended.
The comparison operator in the PowerShell script is changed from '==' to '-eq' to ensure proper evaluation of the condition. This change is necessary because '==' is not a valid comparison operator in PowerShell, and using '-eq' ensures the script runs correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.