Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator for TfsGitRepositoryTool and honor the enabled:false #2420

Conversation

MrHinsh
Copy link
Member

@MrHinsh MrHinsh commented Oct 3, 2024

✨ (TfsGitRepositoryTool): add validation and logging for TfsGitRepositoryTool options

Add a check to ensure the TfsGitRepositoryEnricher is enabled before proceeding, logging a warning if it is not. This prevents unnecessary operations when the feature is disabled. Introduce a default initialization for the Mappings dictionary to avoid null references. Implement a new options validator class, TfsGitRepositoryToolOptionsValidator, to ensure that Mappings is always initialized, enhancing robustness and preventing runtime errors. These changes improve the reliability and maintainability of the tool by ensuring proper configuration and logging.

Closes #2410

…toryTool options

Add a check to ensure the TfsGitRepositoryEnricher is enabled before proceeding, logging a warning if it is not. This prevents unnecessary operations when the feature is disabled. Introduce a default initialization for the Mappings dictionary to avoid null references. Implement a new options validator class, TfsGitRepositoryToolOptionsValidator, to ensure that Mappings is always initialized, enhancing robustness and preventing runtime errors. These changes improve the reliability and maintainability of the tool by ensuring proper configuration and logging.
@MrHinsh MrHinsh enabled auto-merge October 3, 2024 07:51
@nkdagility-actions-bot
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-river-093197403-2420.westeurope.5.azurestaticapps.net

@MrHinsh MrHinsh merged commit e79d28b into main Oct 3, 2024
11 checks passed
@MrHinsh MrHinsh deleted the topic/2410-validation-checks-for-migrationtoolscommontoolstfsgitrepositorytool branch October 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation checks for MigrationTools:CommonTools:TfsGitRepositoryTool
1 participant