Skip to content

Commit

Permalink
refactor(menuSheet): remove disused arg
Browse files Browse the repository at this point in the history
  • Loading branch information
nmotod committed Sep 27, 2023
1 parent f72104a commit 12e1d34
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Modules/Sources/TabBrowser/TabGroup/TabGroupController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public class TabGroupController: UIViewController, TabGroupViewDelegate, TabView
let settingsController = SettingsController(dependency: dependency)

if let menuSheet = sender?.nfl_findResponder(of: MenuSheetController.self) {
menuSheet.show(settingsController, detents: [.large()], animated: true)
menuSheet.show(settingsController, animated: true)
} else {
present(settingsController, animated: true)
}
Expand All @@ -332,7 +332,7 @@ public class TabGroupController: UIViewController, TabGroupViewDelegate, TabView
)

if let menuSheet = sender?.nfl_findResponder(of: MenuSheetController.self) {
menuSheet.show(bookmarkController, detents: [.large()], animated: true)
menuSheet.show(bookmarkController, animated: true)
} else {
present(bookmarkController, animated: true)
}
Expand Down
2 changes: 1 addition & 1 deletion Modules/Sources/Utils/MenuSheet/MenuSheetController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public class MenuSheetController: UIViewController, UICollectionViewDelegate, UI
private var isShowCalled = false

// TODO: remove detents
public func show(_ childViewController: UIViewController, detents: [UISheetPresentationController.Detent]? = nil, animated: Bool) {
public func show(_ childViewController: UIViewController, animated: Bool) {
isShowCalled = true

// to detect interactive dismissal
Expand Down

0 comments on commit 12e1d34

Please sign in to comment.