don't allow scheduling for non-thursdays #10
Conversation
| @@ -223,6 +223,11 @@ func handlePost(res http.ResponseWriter, req *http.Request) { | |||
|
|
|||
| date, _ := time.ParseInLocation("2006-01-02", dateStr, loc) | |||
|
|
|||
| if date.Weekday() != 4 && !time.IsZero() { | |||
There was a problem hiding this comment.
s/4/time.Thursday/
s/time/date/ (that should have popped up when trying to build)
There was a problem hiding this comment.
Also, while you're on it, switch the conditionals around. First the validity-check, then the specific check :) And, strictly speaking, date.IsZero() would imply date.Weekday() != 4, but I think it's still good to have both checks for readability.
There was a problem hiding this comment.
we cannot neglect the date.Weekday()-check, because there might be non-zero dates that are not thursdays (e.g. due to typo in the date).* One could do two ifs, though, but I'd prefer the one-if-version for readability.
*) Or did I misunderstood what you ment?
|
I would prefer to squash these commits (as they are quite small and don't build anyway) and put a "Fixes #8" into the commit-message (in a separate) line. |
|
If you are squashing commits, rebase on master too, while you're at it. I enabled travis builds in the meantime to catch build-failures automatically and it'd be good to include that just for completenes :) |
cherti
force-pushed
the
nononthursdays
branch
from
b983942 to
c0d01e0
Compare
|
done, should be ready for merge now. |
Merovius
force-pushed
the
nononthursdays
branch
from
c0d01e0 to
34a4e2e
Compare
don't allow scheduling for non-thursdays
Don't allow scheduling a talk on a non-thursday. Solves issue #8.