c14h: return error when starting a transaction #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherti
reviewed
Feb 20, 2020
c14h/sql.go
Outdated
|
|
||
| tx, err := db.Begin() | ||
| if err != nil { | ||
| reutrn err |
There was a problem hiding this comment.
There is a typo here, most likely the cause for the CI-failure, other than that, it looks ready to merge for me.
|
m( You know you should've just gone to bed, when you don't even try to build a change before sending it for review… |
chrko
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we are currently being bitten by #8 quite regularly. This is
exacerbated by not checking for an error by tx.Begin() (that's on me, I
presume), so we panic on a nil-pointer, instead of getting an error
message. Unfortunately, I still can't see a super clear-cut way to check
whether an error is caused by this issue and it shouldn't even be an
issue, as *sql.DB is a connection pool - so it should just handle this
transparently, IMO. But at least if we know the error message, we might
get a hint on how to handle that correctly.