Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorV2] Add dot product support #2472

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

djeong20
Copy link
Contributor

This PR adds the ability to compute the dot product between two tensors.

Changes proposed in this PR:

  • Added a new method dot() to the TensorV2 class that computes the dot product between two tensors.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link

taos-ci commented Feb 14, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2472. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@@ -213,4 +213,92 @@ TensorBase::computeBroadcastInfo(const TensorV2 &m) const {
return e;
}

void TensorBase::calculateFlattenDot(
TensorV2 const &input, TensorV2 &output, bool trans, bool trans_in,
Copy link
Member

@skykongkong8 skykongkong8 Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have a function like this! 👍

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taos-ci
Copy link

taos-ci commented Feb 14, 2024

:octocat: cibot: @djeong20, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2472-202402141648500.97616291046143-6c6b012cc62b0dbd4086b0274f51cfd8432ca655/.

This PR adds the ability to compute the dot product between two tensors.

**Changes proposed in this PR:**
- Added a new method dot() to the TensorV2 class that computes the dot product between two tensors.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jijoongmoon jijoongmoon merged commit ec43650 into nnstreamer:main Feb 23, 2024
29 checks passed
@djeong20 djeong20 deleted the feat/tensor_v2/dot branch February 26, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants