Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Application] yolo v2 bug fix #2612

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[Application] yolo v2 bug fix #2612

merged 1 commit into from
Jun 3, 2024

Conversation

baek2sm
Copy link
Contributor

@baek2sm baek2sm commented May 31, 2024

register a custom layer that had been omitted on yolo v2.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link

taos-ci commented May 31, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2612. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@baek2sm baek2sm force-pushed the yolov2_0531 branch 2 times, most recently from 6fb7e41 to 4970ffc Compare May 31, 2024 04:49
@taos-ci
Copy link

taos-ci commented May 31, 2024

:octocat: cibot: @baek2sm, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2612-202405311349130.48604393005371-4970ffc0b872db0f6aeead94c00dde55286b201f/.

@baek2sm
[Application] yolo v2 bug fix
e8ab259 
register a custom layer that had been omitted on yolo v2.

**Self evaluation:**
1. Build test:   [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong <[email protected]>
taos-ci
taos-ci approved these changes May 31, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

djeong20
djeong20 approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DonghakPark
DonghakPark approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EunjuYang
EunjuYang approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit d50487a into nnstreamer:main Jun 3, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeong20 djeong20 djeong20 approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@taos-ci taos-ci taos-ci approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@myungjoo myungjoo myungjoo approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baek2sm @taos-ci @myungjoo @EunjuYang @DonghakPark @djeong20