-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ blas/OpenCL ] SGEMM OpenCL kernels added #2648
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2648. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
GEN_TEST_INPUT(A, ((i * (batch * height * channel) + j * (batch * height) + | ||
k * (width) + l + 1) % | ||
MOD) * | ||
alpha); | ||
GEN_TEST_INPUT_B(B, ((i * (batch * height_b * channel) + | ||
j * (batch * height_b) + k * (width_b) + l + 1) % | ||
MOD) * | ||
alpha); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it intended to skip testing on fp16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running tests on fp32 only as of now
97cea3d
to
d156796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -44,7 +44,7 @@ TEST(blas_kernels, dotCL_sgemv) { | |||
int width = 768; | |||
|
|||
int height_b = 768; | |||
int width_b = 96000; | |||
int width_b = 2048; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any particular reason to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason as such. Was testing with different values. Might have changed it to run this test faster to check other test results quickly.
Added all possible OpenCL kernels for SGEMM Added unit tests Signed-off-by: Debadri Samaddar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
Added SGEMM OpenCL kernels for the following:
noTrans
transA
transB
transAB
Self evaluation:
Signed-off-by: Debadri Samaddar [email protected]