[Graph] rename variable & function names for clarity @open sesame 11/07 21:30 #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baek2sm
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
skykongkong8,
djeong20 and
EunjuYang
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2789. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
baek2sm
changed the title
baek2sm
changed the title
djeong20
approved these changes
Nov 8, 2024
SeoHyungjun
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Currently, InPlaceType is divided into NONE, RESTRICTING, and NON_RESTRICTING.
In my opinion, I think DISABLED is clearer than NONE.
How about using DISABLED, RESTRICTING, and NON_RESTRICTING?
enum class InPlaceType{
DISABLED, /**< layer is not inplace */
RESTRICTING, /**< layer is in-place and does place restriction on layers
ahead of it to be in-place */
NON_RESTRICTING /**< layer is in-place and does NOT place restriction on the
layers ahead of it to be in-place */
};
|
@SeoHyungjun Hmm.. since this enum is "TYPE" of inplace, wouldn't it be more appropriate to use "none" rather than "disabled"? |
currently, same term 'InPlace' means different things depending on context. it could refer to a boolean type value indicating whether in-place operation is supported, or it could refer an enum type value representing the in-place type(type: None, Restriction, Non-Restriction). To clarify this distinction, variables and functions related to the in-place type have been renamed from 'InPlace' to 'InPlaceType'. Similarly, both functions for getting/setting whether it supports inplace (boolean) and those for getting/setting the type of inplace (enum) use the same name, "executeInPlace". To clarify this, I changed the names as follows.. - set the InPlace flag (boolean) : 'setInPlace'. - get the InPlace flag (boolean) : 'getInplace'. - set the type of InPlace (enum) : 'setInPlaceType' - get the type of InPlace (enum) : 'getInPlaceType.' **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Seungbaek Hong <[email protected]>
baek2sm
force-pushed
the
inplace_refact
branch
from
2843c4b to
9d93c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, same term 'InPlace' is used with different meanings by script.
it could refer to a boolean type value indicating whether in-place operation is supported, or it could refer an enum type value representing the in-place type(type: None, Restriction, Non-Restriction).
To clarify this distinction, variables and functions related to the in-place type have been renamed from 'InPlace' to 'InPlaceType'.
Similarly, both functions for getting/setting whether it supports inplace (boolean) and those for getting/setting the type of inplace (enum) use the same name, "executeInPlace".
To clarify this, I've changed the names as follows..
Self evaluation: