[CI] update static checker script to downgrade clang-format version. #2878
Conversation
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
EunjuYang
as code owners
Thank you for your feedback! I have removed the clang-format checks from the static checkers and verifiers. Please take a look. |
| @@ -23,6 +23,7 @@ jobs: | |||
| file-annotations: false | |||
| step-summary: true | |||
| format-review: true | |||
| tidy-checks: '-*' # disable clang-tidy checks. | |||
There was a problem hiding this comment.
Disabling clang-tidy checks because the reports generated are just simple warnings and may provide incorrect results.
Thank you for quick apply!! LGTM again |
This pull request updates the workflow script to run on Ubuntu 22.04 instead of the latest version, allowing the static checker to use clang-format version 14. **Self-evaluation:** 1. Build test: [ ]Passed [ ]Failed [X]Skipped 2. Run test: [ ]Passed [ ]Failed [X]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
This commit aims to eliminate duplicate clang-format checks, which can lead to mismatches. Additionally, it updates the cpp-linter workflow script to run on Ubuntu 22.04 instead of the latest version. **Changes proposed in this PR:** - Remove the C++ checker from the static checker. - Update cpp-linter to operate on Ubuntu 22.04 and disable clang-tidy checks. **Self-evaluation:** 1. Build test: [ ]Passed [ ]Failed [X]Skipped 2. Run test: [ ]Passed [ ]Failed [X]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
force-pushed
the
ci/static_checks/ubuntu_version
branch
from
883a283 to
bd98485
Compare
This pull request updates the workflow script to run on Ubuntu 22.04 instead of the latest version, allowing the static checker to use clang-format version 14.
Self-evaluation: