Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ matrix_transpose ] Divide f16 transpose and f32 transpose with NEON #2898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ matrix_transpose ] Divide f16 transpose and f32 transpose with NEON #2898

wants to merge 2 commits into from

Conversation

skykongkong8
Copy link
Member

  1. no NEON -> matrix_transpose_fallback
  2. NEON, but without f16 -> matrix_transpose_neon (f32 simd)
  3. NEON, with f16 -> 2 + matrix_transpose_neon_f16 (f16 simd)

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@skykongkong8 skykongkong8 mentioned this pull request Jan 23, 2025
Open
@myungjoo @skykongkong8
Add arm-native build and test on Ubuntu
b261f71 
We can run arm natively with github-action.
Test fp16 natively on arm machines!

Signed-off-by: MyungJoo Ham <[email protected]>
@skykongkong8 skykongkong8 force-pushed the pr/transpose/dividef16f32 branch from de6101d to 16655ca Compare January 23, 2025 08:12
@skykongkong8
[ matrix_transpose ] Divide f16 transpose and f32 transpose with NEON
d47d6b4 
1. no NEON -> matrix_transpose_fallback
2. NEON, but without f16 -> matrix_transpose_neon
3. NEON, with f16 -> 2 + matrix_transpose_neon_f16

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: skykongkong8 <[email protected]>
@skykongkong8 skykongkong8 force-pushed the pr/transpose/dividef16f32 branch from 16655ca to d47d6b4 Compare January 24, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skykongkong8 @myungjoo