fix(auth): disable secure cookie for development

noah-platform · Feb 7, 2025 · ef3429e · ef3429e
1 parent 926eba3
commit ef3429e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/auth/server-session/handler/extauth.go b/auth/server-session/handler/extauth.go
@@ -37,13 +37,14 @@ func (s *Server) ExtAuth(c echo.Context) error {
 			l.Warn().Msg("[Server.ExtAuth] invalid session")
 
 			// Expire the invalid session cookie
+			// TODO: Enable secure cookie
 			cookie := &http.Cookie{
 				Name:     sessionCookieName,
 				Value:    "",
 				Path:     "/",
 				Expires:  time.Unix(0, 0),
 				HttpOnly: true,
-				Secure:   true,
+				Secure:   false,
 			}
 			c.SetCookie(cookie)
 

diff --git a/auth/server/handler/login.go b/auth/server/handler/login.go
@@ -64,12 +64,13 @@ func (s *Server) Login(c echo.Context) error {
 		}
 	}
 
+	// TODO: Enable secure cookie
 	cookie := &http.Cookie{
 		Name:     sessionCookieName,
 		Value:    sessionID,
 		Path:     "/",
 		HttpOnly: true,
-		Secure:   true,
+		Secure:   false,
 	}
 	c.SetCookie(cookie)
 

diff --git a/auth/server/handler/login_with_google.go b/auth/server/handler/login_with_google.go
@@ -57,12 +57,13 @@ func (s *Server) LoginWithGoogle(c echo.Context) error {
 		}
 	}
 
+	// TODO: Enable secure cookie
 	cookie := &http.Cookie{
 		Name:     sessionCookieName,
 		Value:    sessionID,
 		Path:     "/",
 		HttpOnly: true,
-		Secure:   true,
+		Secure:   false,
 	}
 	c.SetCookie(cookie)
 

diff --git a/auth/server/handler/logout.go b/auth/server/handler/logout.go
@@ -37,13 +37,14 @@ func (s *Server) Logout(c echo.Context) error {
 		l.Error().Err(err).Msg("[Server.Logout] failed to logout, continuing to clear cookie")
 	}
 
+	// TODO: Enable secure cookie
 	cookie := &http.Cookie{
 		Name:     sessionCookieName,
 		Value:    "",
 		Path:     "/",
 		Expires:  time.Unix(0, 0),
 		HttpOnly: true,
-		Secure:   true,
+		Secure:   false,
 	}
 	c.SetCookie(cookie)