Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @noahnu/eslint-config #18

Merged
merged 1 commit into from
Apr 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 1 addition & 32 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,39 +1,8 @@
module.exports = {
root: true,
extends: ['@tophat/eslint-config/base', '@tophat/eslint-config/jest'],
extends: ['@noahnu/eslint-config'],
parserOptions: {
project: './tsconfig.lint.json',
},
rules: {
'prettier/prettier': [
'error',
{
printWidth: 100,
tabWidth: 4,
semi: false,
trailingComma: 'all' /* Reduces git diff. */,
singleQuote: true,
arrowParens: 'always', // Reduces character diff when adding Typescript types.
},
],
'@typescript-eslint/no-non-null-assertion': 'off',
'no-empty': ['error', { allowEmptyCatch: true }],
'import/order': [
'error',
{
alphabetize: { order: 'asc' },
'newlines-between': 'always',
groups: [
'unknown',
'builtin',
'external',
'internal',
'parent',
'sibling',
'index',
],
},
],
},
ignorePatterns: ['**/.*', 'packages/**/*.js', '**/lib'],
}
2 changes: 2 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ nodeLinker: pnp
npmRegistries:
//registry.npmjs.org/:
npmAuthToken: "${NPM_PUBLISH_TOKEN:-invalid}"

enableTransparentWorkspaces: false
1 change: 0 additions & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ const config = {
},
modulePathIgnorePatterns: ['<rootDir>/.*/lib'],
testTimeout: 30000,
resolver: require.resolve('@tophat/jest-resolver'),
}

module.exports = config
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@
"devDependencies": {
"@jest/types": "^29.6.3",
"@monoweave/plugin-github": "^2.1.0",
"@noahnu/eslint-config": "^1.0.0",
"@tophat/commitizen-adapter": "^1.0.2",
"@tophat/commitlint-config": "^1.0.2",
"@tophat/conventional-changelog-config": "^1.0.1",
"@tophat/eslint-config": "^9.0.0",
"@tophat/eslint-import-resolver-require": "^1.0.0",
"@tophat/jest-resolver": "^0.1.0",
"@types/jest": "^29.5.12",
"@types/node": "^20.12.2",
"@typescript-eslint/eslint-plugin": "^7.4.0",
Expand All @@ -44,8 +42,6 @@
"eslint-plugin-jest": "^27.9.0",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-react": "^7.34.1",
"eslint-plugin-react-hooks": "^4.6.0",
"husky": "^9.0.11",
"jest": "^29.7.0",
"jest-junit": "^16.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/internal-test-utils/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import path from 'node:path'
// @ts-expect-error
Symbol.asyncDispose ??= Symbol.for('asyncDispose')

export type TempDirContext = {
export interface TempDirContext {
dir: string
writeFile: (name: string, contents: string) => Promise<string>
}
Expand Down
4 changes: 2 additions & 2 deletions packages/unused-files/src/api/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { walkDependencyTree } from './walkDependencyTree'

const debug = createDebug('unused-files')

export type FindUnusedFilesOptions = {
export interface FindUnusedFilesOptions {
/**
* Entry files into the codebase. These files are known to be used and any files that
* are dependencies of these entry files are also considered used files.
Expand Down Expand Up @@ -39,7 +39,7 @@ export type FindUnusedFilesOptions = {
cwd?: string
}

export type UnusedFilesResult = {
export interface UnusedFilesResult {
unusedFiles: string[]
}

Expand Down
Loading
Loading