enable es6 class inheritance #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves noble#23 It seems that the tests are broken even without my change. This should be fixed before merging to ensure the compatibility to older versions.
|
It doesn't work without a BLE device. Make sense. Maybe we should mock noble in the future. |
Yes, this is discussed in #22 (comment) What versions of Node.js have you tested this with? I'd like to ideally support v0.10.x or v0.12.x for now ... |
|
Anyone working on this ? Any ideas when this might bet implemented ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #23
It seems that the tests are broken even without my change. This should
be fixed before merging to ensure the compatibility to older versions.