renamed module_name and target_name #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| { | |||
| 'targets': [ | |||
| { | |||
| 'target_name': 'binding', | |||
| 'target_name': 'bluetooth_hci_socket', | |||
There was a problem hiding this comment.
Is it possible to use dashes in place of underscores here?
There was a problem hiding this comment.
No. We can use "<(module_name)" here but in the package file it needs to be a valid C variable name, so no dashes.
See https://github.com/mapbox/node-pre-gyp#module_name
ghost
mentioned this pull request
|
Is this still relevant ? |
|
Please can you forward this change to: https://github.com/abandonware/node-bluetooth-hci-socket/ FYI an updated version has been released: https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make sure you don't use common names that could be used by other modules.
This becomes important when you use "host override" feature of node-pre-gyp