[TK] Refactor ShapedType out of KernelBuffer and Grid #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to change the syntax of KernelBuffer back. I didn't know before looking at tests that it was possible to use .of |
stellaraccident
approved these changes
Feb 26, 2024
Groverkss
force-pushed
the
shaped_type
branch
from
8d3a8bb
to
667fdd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves out KernelBuffer and Grid into lang and creates a ShapedType/ShapedDataType class in _support/shaped_type which can be used elsewhere. This is in preparation for VectorType in TK.
This patch also does some other things: