Add ability to include a plugin when creating driver #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Liddell <[email protected]>
Signed-off-by: daveliddell <[email protected]>
monorimet
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vmfbRunnernow takes an optionalextra_pluginargument to load an executable plugin while the driver is getting created.This option might be used, for example, when loading a vmfb that has an external dependency on a native shared library.
The implementation of this new feature takes advantage of the pre-existing
iree.runtime.flagsfeature and a new IREE python API function. Normally, drivers are managed in a cache. However, setting a flag to specify the plugin has no effect on existing drivers. The API now has a function for creating a driver independent of the cache, to guarantee that any flags are sure to take effect.This PR also includes a fix for the problem of the CI using old cached wheels for iree, as recommended by @monorimet.