Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObjectFifo] Create a new pass to split L2 buffers #659

Merged
merged 22 commits into from
Sep 2, 2024
Merged

[ObjectFifo] Create a new pass to split L2 buffers #659

merged 22 commits into from
Sep 2, 2024

Commits on Sep 2, 2024

  1. [ObjectFifo] Create a new pass to split L2 buffers 

    -- This commit introduces a new pass `--iree-amdaie-split-buffers`
   to split L2 buffers for dealing with Matmul+Elementwise.
-- It addresses sub-action 2 as well from #644

Signed-off-by: Abhishek Varma <[email protected]>
    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b72e687 View commit details
    Browse the repository at this point in the history

  2. [ObjectFifo] Add split-buffers pass to objectfifo pipeline

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e5d70cf View commit details
    Browse the repository at this point in the history

  3. Review comments

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2436d94 View commit details
    Browse the repository at this point in the history

  4. Add more lit tests

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ed248cc View commit details
    Browse the repository at this point in the history

  5. Review comment address including offset/size/stride of linearized buffer

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    11f8d76 View commit details
    Browse the repository at this point in the history

  6. Rectify L2's offset/size for L3->L2 and L2->L1

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    93f5f03 View commit details
    Browse the repository at this point in the history

  7. Add logic to find the offset/bias for the L3->L2 split

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6df1080 View commit details
    Browse the repository at this point in the history

  8. L3->L2 split with new offsets

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1693a6d View commit details
    Browse the repository at this point in the history

  9. Update with comment as well as add two more amdaie.core ops

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9f1c25c View commit details
    Browse the repository at this point in the history

  10. Review comment

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5cf69bd View commit details
    Browse the repository at this point in the history

  11. Review comments 2.0 + add another lit test + Handle edge cases via li… 

    …t test
    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d285fbc View commit details
    Browse the repository at this point in the history

  12. Address other corner cases + review comments

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    500e0a7 View commit details
    Browse the repository at this point in the history

  13. Create a separate splitting utility

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a5ce10c View commit details
    Browse the repository at this point in the history

  14. Rename + refactor + lit test fix

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    94ef347 View commit details
    Browse the repository at this point in the history

  15. Offline review comments

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5d91974 View commit details
    Browse the repository at this point in the history

  16. Removed unused DenseMap 

    Co-authored-by: Jorn Tuyls <[email protected]>
    @Abhishek-Varma @jtuyls
    Abhishek-Varma and jtuyls committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    75083a8 View commit details
    Browse the repository at this point in the history

  17. nit TODO comment suggestion change 

    Co-authored-by: Jorn Tuyls <[email protected]>
    @Abhishek-Varma @jtuyls
    Abhishek-Varma and jtuyls committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9bbcac1 View commit details
    Browse the repository at this point in the history

  18. bunch -> vector comment change 

    Co-authored-by: Jorn Tuyls <[email protected]>
    @Abhishek-Varma @jtuyls
    Abhishek-Varma and jtuyls committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    8a11c00 View commit details
    Browse the repository at this point in the history

  19. Review comments 2nd Sept

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    20299cf View commit details
    Browse the repository at this point in the history

  20. Trivial review comments

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1b605fd View commit details
    Browse the repository at this point in the history

  21. Final review comment

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5b33560 View commit details
    Browse the repository at this point in the history

  22. Review comment nit + tiny refactor

    @Abhishek-Varma
    Abhishek-Varma committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e65f66e View commit details
    Browse the repository at this point in the history