[ObjectFifo] Combine Logical ObjectFifos for reuse #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhishek-Varma
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
jtuyls
as code owners
jtuyls
reviewed
Sep 9, 2024
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
| // Step 3. PICK the CoreOps associated with the 1:1 L2->L1. | ||
| // For the first Core op we'll insert Read at the end. It doesn't matter | ||
| // for now so we're gonna insert it right before amdaie.end op. | ||
| CoreOp firstCoreOp = fetchUniqueCoreOp(newFirstL2ToL1DmaOp); |
There was a problem hiding this comment.
What if there are more than 2 target core ops per DMA?
There was a problem hiding this comment.
I'm already asserting on that here.
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIELogicalObjFifoSplittingUtils.cpp
Show resolved
Hide resolved
Able to get combined op - need to change the corresponding L2 target.
…dating shape of L2
Abhishek-Varma
force-pushed
the
avarma_combine
branch
from
a017a38
to
be4f6f9
Compare
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new pass
iree-amdaie-combine-logical-objectfifos-for-connection-reuse(can rename) which is the follow-up pass foriree-amdaie-split-logical-objectfifos-for-connection-reuse.It contains lot of refactor along with the pass logic itself. Since it's a non-trivial pass, I've tried adding asserts/checks (to the extend I could) - currently starting off with base lit test.
Aims to address point 4 in #644.