Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #873 due to token corruption found during 3.2.0 release QA #946

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Draft

Revert #873 due to token corruption found during 3.2.0 release QA #946

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3221e4
Revert "Fix Masking-related token corruption issue that oddly only ma…
renxida Feb 10, 2025
2f5afcd
remove xfail
renxida Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion shortfin/python/shortfin_apps/llm/components/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ async def run(self):
m.fill(
1 # Must pad with a nonzero value because a division by 0 during softmax floods clobber page (page 0) in cache with NaN values.
)
m.items = [req.start_position + 1 for req in self.exec_requests]
m.items = [
req.start_position + len(req.input_token_ids)
for req in self.exec_requests
]
seq_lens_host.copy_to(seq_lens)

# Populate cache pages.
Expand Down
Loading