Upstream for qa issue #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered an issue with producing blocks in the devnet environment when the --dev.period flag is set to 0, which is its default value. The issue was caused by an infinite wait on a channel read in one of the goroutines inside the `StartMining` function. Additionally, in this PR, I removed the unused `noempty` variable from the `stage_mining_exec.go` file. The logic remains unchanged—I only removed if blocks that were never executed.
…#13728) Previously `IsServiceTransaction` relied on the `certifier` being set by `Initialize`. But in some contexts (e.g. Issue erigontech#13588) `IsServiceTransaction` is called w/o `Initialize`.
Polygon node crashed with the following error ``` [EROR] [02-06|09:17:35.922] polygon sync crashed - stopping node err="pos sync heimdall failed: span scraper failed: can't fetch id range: error while fetching data from Heimdall: url='https://heimdall-api-amoy.polygon.technology/bor/latest-span', status=404, body='<!DOCTYPE html>\n<html>\n\n<head>\n <title>Error ・ Cloudflare Access</title> ``` This should not be a failing error as it is likely due to Cloudflare masking downtime of the Heimdall endpoint that are currently covered by `ErrServiceUnavailable`. We specifically check for `404` status codes as other status codes like `403` may signal other errors such as Cloudflare's DDoS protection.
…to fold.." (erigontech#13735) This reverts commit 1f87c16.
…h#13743) fixes erigontech#13739 I deactivated most of them, but: - I didn't delete them, maybe @antonis19 you want to keep it, but demote to debug or trace log levels instead? - there is another block of code apparently doing only logs, but I didn't remove it bc I'm not familiar with the code and it looks like only getters, but maybe it could have some side effect, I didn't dig deeper, maybe you want to confirm.
…h#13740) Using the param instead of returned value. Fixes one more rpc-compat hive test
…k building (erigontech#13750) I think the code speak for itself
setunapo
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick. Revert erigontech#13509 "Commitment: do not use cell getter function …