Rule.exec should call info.wait if rule.replies exists #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Bitdeli Badge to README
|
webot 里的实现是在 https://github.com/node-webot/webot/blob/master/lib/webot.js#L430 好像确实应该转到 rule.js 里来。帮忙把那边也改掉吧？ |
|
挪过来了。本来是根据err来跳过info.wait，我自作主张用了一个新的参数来控制，不知是否妥当？ |
|
已经有一个 |
|
不过好像目的不一样。。。 那就加上吧。。。 |
| info.wait('_reply_' + rule.name); | ||
| } | ||
| oldcb(err, next); | ||
| } |
There was a problem hiding this comment.
不过为什么要新加一个函数？直接加一句 info.wait 不可以？又不是异步操作
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.