Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow man-page from non-CLI #143

Merged
merged 1 commit into from
Nov 16, 2024
Merged

chore: allow man-page from non-CLI #143

merged 1 commit into from
Nov 16, 2024

Conversation

RedYetiDev
Copy link
Member

😅 This branch should've created on my fork, not this repo. Regardless, this is a chore for post #137 to allow the man-page to be generated programmatically.

@RedYetiDev RedYetiDev requested a review from a team as a code owner November 16, 2024 15:25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/generators/man-page/index.mjs:75

  • The new conditional behavior introduced by 'if (options.output)' should be covered by tests to ensure it works as expected.
if (options.output) {
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@flakey5 flakey5 merged commit bbf44c4 into main Nov 16, 2024
7 checks passed
@flakey5 flakey5 deleted the RedYetiDev/refspec branch November 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants