Skip to content

Commit

Permalink
jenkins: cleanup VersionSelectorScript.groovy (#3447)
Browse files Browse the repository at this point in the history 
- Remove lines that only exclude EoL versions
- Reference currently supported versions everywhere
  • Loading branch information
@targos
targos authored Aug 11, 2023
1 parent ca10721 commit 7b5d0a4
Showing 1 changed file with 37 additions and 76 deletions.
113 changes: 37 additions & 76 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,120 +20,81 @@ def buildExclusions = [
// Machine Label, Build Type, Node Version

// Linux -------------------------------------------------
[ /^centos7-(arm)?(64|32)-gcc48/,anyType, gte(10) ],
[ /^centos7-(arm)?(64|32)-gcc6/, anyType, lt(10) ],
[ /^centos7-(arm)?(64|32)-gcc6/, anyType, gte(14) ], // 14.x: gcc6 builds stop
[ /^centos7-(arm)?(64)-gcc8/, anyType, lt(14) ], // 14.x: gcc8 builds start
[ /^centos7-(arm)?(64|32)-gcc48/, anyType, gte(16) ],
[ /^centos7-(arm)?(64|32)-gcc6/, anyType, gte(16) ], // 14.x: gcc6 builds stop
[ /^centos7-(arm)?(64)-gcc8/, anyType, gte(18) ], // 18.x: centos7 builds stop
[ /^centos7-64/, releaseType, lt(12) ],
[ /^centos7-64/, anyType, gte(18) ],
[ /debian8-x86/, anyType, gte(10) ], // 32-bit linux for <10 only
[ /debian8/, anyType, gte(13) ],
[ /debian8-x86/, anyType, gte(16) ], // 32-bit linux for <10 only
[ /debian8/, anyType, gte(16) ],
[ /debian9/, anyType, gte(16) ],
[ /rhel7/, anyType, gte(18) ],
[ /rhel8/, releaseType, lt(18) ],
[ /rhel8/, anyType, lt(14) ],
[ /^ubuntu1804/, anyType, lt(10) ], // probably temporary
[ /^ubuntu1604-32/, anyType, gte(10) ], // 32-bit linux for <10 only
[ /^ubuntu1604-32/, anyType, gte(16) ], // 32-bit linux for <10 only
[ /^ubuntu1604-64/, anyType, gte(16) ],
[ /^ubuntu2004/, anyType, lt(13) ], // Ubuntu 20 doesn't have Python 2
[ /^alpine-latest-x64$/, anyType, lt(13) ], // Alpine 3.12 doesn't have Python 2

// Linux PPC LE ------------------------------------------
[ /^centos7-ppcle/, anyType, lt(10) ],
[ /^centos7-ppcle/, anyType, gte(18) ],

// Linux S390X --------------------------------------------
[ /s390x/, anyType, lt(6) ],
[ /lto-s390x/, anyType, lt(16) ],

// ARM --------------------------------------------------
[ /^debian8-docker-armv7$/, releaseType, lt(10) ],
[ /^debian8-docker-armv7$/, anyType, gte(12) ],
[ /^debian9-docker-armv7$/, anyType, lt(10) ],
[ /^debian10-armv7l$/, anyType, gte(20) ], // gcc 10 requires newer libstdc++
[ /^cross-compiler-ubuntu1604-armv[67]-gcc-4.9/, anyType, gte(12) ],
[ /^cross-compiler-ubuntu1604-armv[67]-gcc-6/, anyType, lt(12) ],
[ /^cross-compiler-ubuntu1604-armv[67]-gcc-6/, anyType, gte(14) ],
[ /^cross-compiler-ubuntu1804-armv7-gcc-6/, anyType, lt(14) ],
[ /^cross-compiler-ubuntu1804-armv7-gcc-6/, anyType, gte(16) ],
[ /^cross-compiler-ubuntu1804-armv7-gcc-8/, anyType, lt(16) ],
[ /^cross-compiler-ubuntu1804-armv7-gcc-8/, anyType, gte(18) ],
[ /^cross-compiler-rhel8-armv7-gcc-8-glibc-2.28/,anyType, lt(18) ],
[ /^cross-compiler-rhel8-armv7-gcc-8-glibc-2.28/,anyType, gte(20) ],
[ /^cross-compiler-rhel8-armv7-gcc-10-glibc-2.28/,anyType, lt(20) ],
[ /^ubuntu1604-arm64/, anyType, gte(14) ],
[ /^debian8-docker-armv7$/, anyType, gte(16) ],
[ /^debian10-armv7l$/, anyType, gte(20) ], // gcc 10 requires newer libstdc++
[ /^cross-compiler-ubuntu1604-armv[67]-gcc-4.9/, anyType, gte(16) ],
[ /^cross-compiler-ubuntu1604-armv[67]-gcc-6/, anyType, gte(16) ],
[ /^cross-compiler-ubuntu1804-armv7-gcc-6/, anyType, gte(16) ],
[ /^cross-compiler-ubuntu1804-armv7-gcc-8/, anyType, gte(18) ],
[ /^cross-compiler-rhel8-armv7-gcc-8-glibc-2.28/, anyType, lt(18) ],
[ /^cross-compiler-rhel8-armv7-gcc-8-glibc-2.28/, anyType, gte(20) ],
[ /^cross-compiler-rhel8-armv7-gcc-10-glibc-2.28/, anyType, lt(20) ],
[ /^ubuntu1604-arm64/, anyType, gte(16) ],

// Windows -----------------------------------------------
// https://github.com/nodejs/build/blob/main/doc/windows-visualstudio-supported-versions.md
// Release Builders - should only match one VS version per Node.js version
[ /vs2013/, releaseType, gte(6) ],
[ /vs2015/, releaseType, ltGte(6, 10) ],
[ /vs2017/, releaseType, ltGte(10, 14) ],
[ /vs2019/, releaseType, lt(14) ],
[ /vs2019-arm64/, releaseType, lt(19) ],
[ /vs2013/, releaseType, gte(16) ],
[ /vs2015/, releaseType, gte(16) ],
[ /vs2017/, releaseType, gte(16) ],
[ /vs2019-arm64/, releaseType, lt(20) ],
// VS versions supported to compile Node.js - also matches labels used by test runners
[ /vs2013(-\w+)?$/, testType, gte(6) ],
[ /vs2015(-\w+)?$/, testType, gte(10) ],
[ /vcbt2015(-\w+)?$/, testType, gte(10) ],
[ /vs2017(-\w+)?$/, testType, ltGte(8, 15) ],
[ /vs2019(-\w+)?$/, testType, lt(13) ],
[ /vs2013(-\w+)?$/, testType, gte(16) ],
[ /vs2015(-\w+)?$/, testType, gte(16) ],
[ /vcbt2015(-\w+)?$/, testType, gte(16) ],
[ /vs2017(-\w+)?$/, testType, gte(16) ],
[ /vs2022(-\w+)?$/, testType, lt(20) ], // Temporarily compile Node v20+ on both VS2019 and VS2022
[ /vs2015-x86$/, testType, gte(10) ], // compile arm64/x86 only once
[ /vs2017-x86$/, testType, ltGte(10, 14) ],
[ /vs2019-x86$/, testType, lt(14) ],
[ /vs2019-arm64$/, testType, lt(14) ],
[ /vs2015-x86$/, testType, gte(16) ], // compile arm64/x86 only once
[ /vs2017-x86$/, testType, gte(16) ],
[ /vs2022-x86$/, testType, lt(20) ], // Temporarily compile Node v20+ arm64 and x86 on both VS2019 and VS2022
[ /vs2022-arm64$/, testType, lt(20) ],
[ /COMPILED_BY-\w+-arm64$/, testType, lt(19) ], // run tests on arm64 for >=19
[ /COMPILED_BY-\w+-arm64$/, testType, lt(20) ], // run tests on arm64 for >=19
// VS versions supported to build add-ons
[ /vs2013-COMPILED_BY/, testType, gte(9) ],
[ /vs2015-COMPILED_BY/, testType, gte(19) ],
[ /vcbt2015-COMPILED_BY/, testType, gte(19) ],
[ /vs2017-COMPILED_BY/, testType, lt(8) ],
[ /vs2019-COMPILED_BY/, testType, lt(12) ],
[ /vs2022-COMPILED_BY/, testType, lt(16) ],
[ /vs2013-COMPILED_BY/, testType, gte(16) ],
[ /vs2015-COMPILED_BY/, testType, gte(20) ],
[ /vcbt2015-COMPILED_BY/, testType, gte(20) ],
// Exclude some redundant configurations
// https://github.com/nodejs/build/blob/main/doc/node-test-commit-matrix.md
[ /win10.*COMPILED_BY-vs2017/, testType, lt(10) ], // vcbt2015 runs on win10 for <10
[ /win10.*COMPILED_BY-vs2017/, testType, gte(13) ], // vs2019 runs on win10 for >=13
[ /win10.*COMPILED_BY-vs2017/, testType, gte(16) ], // vs2019 runs on win10 for >=13

// SmartOS -----------------------------------------------
[ /^smartos18/, anyType, lt(12) ],
[ /^smartos18/, releaseType, gte(14) ],
[ /^smartos18/, anyType, gte(16) ],
[ /^smartos18/, releaseType, gte(16) ],
[ /^smartos18/, anyType, gte(16) ],

// AIX PPC64 ---------------------------------------------
[ /aix71/, anyType, lt(10) ],
[ /aix71/, anyType, gte(15) ],
[ /aix72/, anyType, lt(15) ],
[ /aix71/, anyType, gte(16) ],

// Shared libs docker containers -------------------------
[ /ubi81_sharedlibs/, anyType, lt(13) ],
[ /sharedlibs_debug_x64/, anyType, gte(18) ],
[ /sharedlibs_openssl3/, anyType, lt(15) ],
[ /sharedlibs_openssl111/, anyType, lt(11) ],
[ /sharedlibs_openssl110/, anyType, lt(9) ],
[ /sharedlibs_openssl110/, anyType, gte(12) ],
[ /sharedlibs_openssl102/, anyType, gte(10) ],
[ /sharedlibs_fips20/, anyType, gte(10) ],
[ /sharedlibs_withoutintl/, anyType, lt(9) ],
[ /sharedlibs_withoutssl/, anyType, lt(10) ],
[ /sharedlibs_shared/, anyType, lt(9) ],
[ /sharedlibs_openssl110/, anyType, gte(16) ],
[ /sharedlibs_openssl102/, anyType, gte(16) ],
[ /sharedlibs_fips20/, anyType, gte(16) ],

// OSX ---------------------------------------------------
[ /osx11-release-pkg/, releaseType, lt(16) ],
[ /osx11-arm64-release-tar/, releaseType, lt(16) ],
[ /osx11-x64-release-tar/, releaseType, lt(20) ],
[ /osx1015-release-pkg/, releaseType, gte(16) ],
[ /osx1015-release-tar/, releaseType, gte(20) ],
[ /^osx11/, testType, lt(15) ],

// FreeBSD -----------------------------------------------
[ /^freebsd10/, anyType, gte(11) ],
[ /^freebsd10/, anyType, gte(16) ],

// Source / headers / docs -------------------------------
[ /^centos7-release-sources$/, releaseType, lt(10) ],
[ /^centos7-release-sources$/, releaseType, gte(18) ],
[ /^rhel8-release-sources$/, releaseType, lt(18) ],

Expand Down

0 comments on commit 7b5d0a4

Please sign in to comment.