Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macOS 10.x release machines from inventory #3532

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Oct 19, 2023

Main changes

This will remove macOS 10.x release machines from the inventory

Blockers

Context

On November 1, 2023 macOS 10.x won't be able to notarize the binaries.

Related: #3385 (comment)
Related: nodejs/node#50291

@UlisesGascon
Copy link
Member Author

Not sure what to do with the nearform machine, the Orka one can be repurposed in #3240. Should I open an issue for these machines? So we can keep track of them in the meantime?

@UlisesGascon
Copy link
Member Author

Just to clarify, the idea is to remove macOS 10.x from the configurations available, so the pipelines will ignore them.

Screenshot 2023-10-19 at 20 22 56

@targos
Copy link
Member

targos commented Oct 22, 2023

Not sure what to do with the nearform machine, the Orka one can be repurposed in #3240. Should I open an issue for these machines? So we can keep track of them in the meantime?

Yes, please open an issue. I suggest we reserve it for future macOS updates in CI (to 13 or 14).

@UlisesGascon
Copy link
Member Author

This is ready to review. The agents are now removed from Jenkins, so we can remove the machines from the inventory. Here is the issue to track nearform one: #3537.

I will manually remove the Orka instance in the meantime.

@richardlau
Copy link
Member

@UlisesGascon if you haven't already you'll also need to remove them from the inventory in the secrets repo.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Oct 26, 2023

@UlisesGascon if you haven't already you'll also need to remove them from the inventory in the secrets repo.

Great point! I will do it soon :) Completed in https://github.com/nodejs-private/secrets/pull/289

@UlisesGascon UlisesGascon merged commit c3b4490 into nodejs:main Oct 26, 2023
1 check passed
@UlisesGascon UlisesGascon deleted the feat/remove-macos10-hw branch October 26, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants