-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gitexec to v2.0.1 #66
Conversation
d0715d2
to
894009b
Compare
@rvagg: this is clearly broken and we need to fix it, why approve it :P |
Alright, after seeing the source code, I don't think changelog-maker can ever work on Windows native cmd... I'm not sure how to make all of those posix stuff work on Windows like
So, if after spending some time @rvagg you don't think we can make it work nice on Windows native cmd, we should revert the gitexec shell change and release 2.0.1 and then update to 2.0.1 here. We'll just need to list that changelog-maker requires bash. I managed to test the master branch on my Windows VM with msys2
|
Unless, we split the subcommands and we joined them thus skipping backticks and It might be doable. |
yeah, it's going to be the
|
@rvagg sounds good, can you push your suggestion on this branch and ping me? |
I started playing with this today but it's way more complex than I imagined! there's a lot of bash subcommand nesting going on in the original structure that's a bit awkward to pull apart. An interesting challenge though; but very low priority so no guarantees that it's going to get done any time soon. |
894009b
to
fbc1311
Compare
Currently, this breaks Windows testing. More specifically this patch: rvagg/gitexec@51ad38d
This PR is split from #61 so that we tackle the Windows issue separately.
Closes #54