Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security post release blogpost #785

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Mar 22, 2024

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (e3e19b3) to head (0db4650).
Report is 5 commits behind head on main.

Current head 0db4650 differs from pull request most recent head 0c11384

Please upload reports for the commit 0c11384 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   83.08%   82.97%   -0.12%     
==========================================
  Files          37       37              
  Lines        4251     4200      -51     
==========================================
- Hits         3532     3485      -47     
+ Misses        719      715       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marco-ippolito marco-ippolito force-pushed the feat-pos-release-blogpost branch 2 times, most recently from 4a6802e to 725b4e2 Compare March 25, 2024 08:54
@marco-ippolito marco-ippolito marked this pull request as ready for review March 25, 2024 08:54
@marco-ippolito
Copy link
Member Author

once this lands: #788 we can automatically pull in dependencies and openssl updates

@RafaelGSS RafaelGSS changed the title feat: security pos release blogpost feat: security post release blogpost Mar 26, 2024
@marco-ippolito
Copy link
Member Author

blocked by: #788
I will have to update the workflow once this lands

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it today and it seems to have a lint error when updating the file.

Also, update use the vulnerabilities.json to read the date and patch author

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check lint please

lib/github/templates/security-post-release.md Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

richardlau commented Apr 19, 2024

@marco-ippolito
Copy link
Member Author

Update

I thought that's for when the security release is delayed

@marco-ippolito
Copy link
Member Author

Check lint please

lint seems to pass locally what command are you running?

@richardlau
Copy link
Member

Update

I thought that's for when the security release is delayed

I thought we also did that to denote the update from the pre-announcement.

@RafaelGSS
Copy link
Member

RafaelGSS commented Apr 19, 2024

Check lint please

lint seems to pass locally what command are you running?

IIRC we are using * instead of - for listing vulnerabilities (or the inverse 😅) and the linter of nodejs.org complains. Try to create a real example with vulnerabilities and run lint

@RafaelGSS
Copy link
Member

@marco-ippolito do you need some help here?

@marco-ippolito
Copy link
Member Author

@marco-ippolito do you need some help here?

Feel free to take over

@marco-ippolito
Copy link
Member Author

Also thir PR should fix https://github.com/nodejs-private/security-release/issues/27

@RafaelGSS RafaelGSS merged commit 9104079 into nodejs:main Jun 24, 2024
9 checks passed
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late LGTM 😄

This was referenced Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants