Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(git-node): followup fix for supported wpt jsons #855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(git-node): followup fix for supported wpt jsons #855

wants to merge 1 commit into from

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Sep 18, 2024 •
edited
Loading

@RedYetiDev RedYetiDev changed the title fix: followup fix for supported wpt jsons fix(git-node): followup fix for supported wpt jsons Sep 24, 2024
@RedYetiDev
Copy link
Member Author

@nodejs/node-core-utils this hasn't had any objections, and without it, updating the WPT is harder (for interfaces)

@aduh95
Copy link
Contributor

aduh95 commented Nov 4, 2024

It's not immediately obvious why this change is needed now, did the WPT suite start using non-JSON files recently?

@RedYetiDev
Copy link
Member Author

Yes. In a recent PR, the WebCryptoAPI status file was changed from a JSON file to a JS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedYetiDev @aduh95 @panva