[compiler] Avoid ambiguous symbol error with MSVC

The MSVC compiler doesn't like this use of `detail` and says it could be either v8::internal::compiler::detail or v8::internal::compiler::turboshaft::detail
nodejs · Jul 26, 2023 · dca9b9e · dca9b9e
1 parent 38ededd
commit dca9b9e
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/deps/v8/src/compiler/backend/instruction-selector-adapter.h b/deps/v8/src/compiler/backend/instruction-selector-adapter.h
@@ -25,13 +25,14 @@
 // a temporary fallback for these functions such that compilation is possible
 // while transitioning the instruction selector incrementally. Once all uses
 // of Node*, BasicBlock*, ... have been replaced, remove those fallbacks.
-#define DECLARE_UNREACHABLE_TURBOSHAFT_FALLBACK(ret, name)             \
-  template <typename... Args>                                          \
-  std::enable_if_t<Adapter::IsTurboshaft &&                            \
-                       detail::AnyTurbofanNodeOrBlock<Args...>::value, \
-                   ret>                                                \
-  name(Args...) {                                                      \
-    UNREACHABLE();                                                     \
+#define DECLARE_UNREACHABLE_TURBOSHAFT_FALLBACK(ret, name)                     \
+  template <typename... Args>                                                  \
+  std::enable_if_t<Adapter::IsTurboshaft &&                                    \
+                       v8::internal::compiler::detail::AnyTurbofanNodeOrBlock< \
+                           Args...>::value,                                    \
+                   ret>                                                        \
+  name(Args...) {                                                              \
+    UNREACHABLE();                                                             \
   }
 
 namespace v8::internal::compiler {