Skip to content

Commit

Permalink
test: remove test that is no longer needed
Browse files Browse the repository at this point in the history
Refs: #53382

This test fails on OpenSS32 because it complains the key being
used is too short.

It seems to have been missed when the test suite was udpated to have
a Makefile to generate key material as the keys are hard coded in the
test as opposed to being read in from the fixtures/key directory.

Looking at the test it was added 8 years ago in
cdde9a3
to test the case where the key did not have a newline at the end.

However, looking at the fixtures used in the test suite I see that for
the test
https://github.com/nodejs/node/blob/main/test/parallel/test-tls-inception.js,
the key test/fixtures/keys/rsa_private.pem and certificate
test/fixtures/keys/rsa-cert.crt do not have any newlines (which I
think is the case for most of the test keys/certificates now)
so it would already cover the same case.

So while we could update the test to use a larger key, it seems like it
is redundant and we can just remove it.

Signed-off-by: Michael Dawson <[email protected]>
  • Loading branch information
mhdawson committed Sep 16, 2024
1 parent 7feff24 commit 0b3b1fe
Showing 1 changed file with 0 additions and 80 deletions.
80 changes: 0 additions & 80 deletions test/parallel/test-tls-cert-regression.js

This file was deleted.

0 comments on commit 0b3b1fe

Please sign in to comment.