Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
  • Loading branch information
3 people authored Nov 13, 2024
1 parent 29ccc97 commit 23fe596
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/create-release-proposal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,15 @@ jobs:
- name: Install @node-core/utils
run: npm install -g @node-core/utils

- name: Set variables
run: |
echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
- name: Configure @node-core/utils
run: |
ncu-config set branch "${RELEASE_BRANCH}"
ncu-config set upstream origin
ncu-config set username "$USERNAME"
ncu-config set token "$GH_TOKEN"
ncu-config set jenkins_token "$JENKINS_TOKEN"
ncu-config set repo "${REPOSITORY}"
ncu-config set owner "${OWNER}"
ncu-config set repo "$(echo "$GITHUB_REPOSITORY" | cut -d/ -f2)"
ncu-config set owner "${GITHUB_REPOSITORY_OWNER}"
env:
USERNAME: ${{ secrets.JENKINS_USER }}
GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions tools/actions/create-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ git node release --prepare --skipBranchDiff
# We use it to not specify the branch name as it changes based on
# the commit list (semver-minor/semver-patch)
git config push.default current
echo "/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }" > temp.awk
awk -f temp.awk doc/changelogs/CHANGELOG_V23.md > pr-body.md
MATCHER="/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }"
awk $MATCHER doc/changelogs/CHANGELOG_V23.md > pr-body.md

Check failure on line 12 in tools/actions/create-release.sh

View workflow job for this annotation

GitHub Actions / lint-sh

/home/runner/work/node/node/tools/actions/create-release.sh:12:5: Double quote to prevent globbing and word splitting.
gh pr create --body-file pr-body.md
# TODO: ammend with proposal PR

0 comments on commit 23fe596

Please sign in to comment.