src: use explicit C++17 fallthrough

This passes the strictest -Wimplicit-fallthrough setting. PR-URL: #46251 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 20, 2023 · c47ad58 · c47ad58
1 parent 5d0946a
commit c47ad58
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/crypto/crypto_clienthello.cc b/src/crypto/crypto_clienthello.cc
@@ -29,7 +29,7 @@ void ClientHelloParser::Parse(const uint8_t* data, size_t avail) {
     case kWaiting:
       if (!ParseRecordHeader(data, avail))
         break;
-      // Fall through
+      [[fallthrough]];
     case kTLSHeader:
       ParseHeader(data, avail);
       break;

diff --git a/src/inspector_io.cc b/src/inspector_io.cc
@@ -74,7 +74,7 @@ class RequestToServer {
     switch (action_) {
       case TransportAction::kKill:
         server->TerminateConnections();
-        // Fallthrough
+        [[fallthrough]];
       case TransportAction::kStop:
         server->Stop();
         break;

diff --git a/src/node_i18n.cc b/src/node_i18n.cc
@@ -794,12 +794,12 @@ static int GetColumnWidth(UChar32 codepoint,
         return 2;
       }
       // If ambiguous_as_full_width is false:
-      // Fall through
+      [[fallthrough]];
     case U_EA_NEUTRAL:
       if (u_hasBinaryProperty(codepoint, UCHAR_EMOJI_PRESENTATION)) {
         return 2;
       }
-      // Fall through
+      [[fallthrough]];
     case U_EA_HALFWIDTH:
     case U_EA_NARROW:
     default:

diff --git a/src/node_zlib.cc b/src/node_zlib.cc
@@ -797,7 +797,7 @@ void ZlibContext::DoThreadPoolWork() {
             break;
           }
 
-          // fallthrough
+          [[fallthrough]];
         case 1:
           if (next_expected_header_byte == nullptr) {
             break;
@@ -817,7 +817,7 @@ void ZlibContext::DoThreadPoolWork() {
           CHECK(0 && "invalid number of gzip magic number bytes read");
       }
 
-      // fallthrough
+      [[fallthrough]];
     case INFLATE:
     case GUNZIP:
     case INFLATERAW: