Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid allocation in the Size method for BASE64URL and BASE64 #53550

Closed
wants to merge 16 commits into from
Closed

src: avoid allocation in the Size method for BASE64URL and BASE64 #53550

Changes from 7 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dcb9718
src: avoid allocation in the Size method for BASE64URL and BASE64
lemire Jun 22, 2024
a69442c
simplify the function
lemire Jun 22, 2024
cf1d6b9
lint
lemire Jun 22, 2024
fb76dbd
more simplification
lemire Jun 22, 2024
2588eb9
fix typo
lemire Jun 22, 2024
b6a694d
explicit cast
lemire Jun 22, 2024
9ae78a4
lint
lemire Jun 22, 2024
87a47a7
adjust the output size more precisely, for the simple cases
lemire Jun 23, 2024
e698118
lint
lemire Jun 23, 2024
3b177fc
using string view
lemire Aug 31, 2024
de7c029
lint
lemire Aug 31, 2024
c3bc997
Merge branch 'main' into fix_problem_with_size_base64
lemire Aug 31, 2024
f6ba611
typo
lemire Sep 1, 2024
486ec52
lint
lemire Sep 1, 2024
5f44e48
Merge branch 'main' into fix_problem_with_size_base64
lemire Sep 8, 2024
3ad4996
Merge branch 'main' into fix_problem_with_size_base64
lemire Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions src/string_bytes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,12 +449,10 @@ Maybe<size_t> StringBytes::StorageSize(Isolate* isolate,
break;

case BASE64URL:
data_size = simdutf::base64_length_from_binary(str->Length(),
simdutf::base64_url);
break;

case BASE64:
data_size = simdutf::base64_length_from_binary(str->Length());
data_size = str->Length() % 4 <= 1
? str->Length() / 4 * 3
: str->Length() / 4 * 3 + (str->Length() % 4) - 1;
mildsunrise marked this conversation as resolved.
Show resolved Hide resolved
break;

case HEX:
Expand Down Expand Up @@ -493,16 +491,11 @@ Maybe<size_t> StringBytes::Size(Isolate* isolate,
case UCS2:
return Just(str->Length() * sizeof(uint16_t));

case BASE64URL: {
String::Value value(isolate, str);
return Just(simdutf::base64_length_from_binary(value.length(),
simdutf::base64_url));
}

case BASE64: {
String::Value value(isolate, str);
return Just(simdutf::base64_length_from_binary(value.length()));
}
case BASE64URL:
case BASE64:
return Just<size_t>(str->Length() % 4 <= 1 ? str->Length() / 4 * 3
: str->Length() / 4 * 3 +
(str->Length() % 4) - 1);

case HEX:
return Just<size_t>(str->Length() / 2);
Expand Down
Loading