Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add receiver to fast api callback methods #54408

Merged
merged 4 commits into from
Sep 28, 2024
Merged

src: add receiver to fast api callback methods #54408

merged 4 commits into from
Sep 28, 2024

Commits on Aug 16, 2024

  1. src: add receiver to fast api callback methods 

    When creating an fast api the callback might use the receiver. In that
case if the internal binding is destructured the method won't have
access to the reciver and it will throw. Passing the receiver as second
argument ensures the receiver is available.
    @Ceres6
    Ceres6 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d57f479 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fixup! src: add receiver to fast api callback methods

    @Ceres6
    Ceres6 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b3e6133 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Joyee Cheung <[email protected]>
    @Ceres6 @joyeecheung
    Ceres6 and joyeecheung authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a5a555c View commit details
    Browse the repository at this point in the history

  3. Update doc/contributing/adding-v8-fast-api.md 

    Co-authored-by: Aviv Keller <[email protected]>
    @Ceres6 @RedYetiDev
    Ceres6 and RedYetiDev authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    41522d4 View commit details
    Browse the repository at this point in the history