build: support up to python 3.13 in android-configure #54529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
RedYetiDev
added
python
lpinca
approved these changes
Aug 24, 2024
VoltrexKeyva
approved these changes
Aug 25, 2024
jasnell
approved these changes
Aug 25, 2024
UlisesGascon
approved these changes
Aug 25, 2024
|
A CI is needed for this to be |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Per the docs,
I'm not sure if triagers are supposed to mark things as |
|
@RedYetiDev ... if the CI flakes again, please rebase to pick up the recent flaky test additions to parallel.status and try CI again. |
RedYetiDev
force-pushed
the
patch-109
branch
from
880703b
to
c64f32e
Compare
|
Rebased :-) |
|
CI LGTM |
|
Can this land? |
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54529 ✔ Done loading data for nodejs/node/pull/54529 ----------------------------------- PR info ------------------------------------ Title build: support up to python 3.13 in android-configure (#54529) Author Aviv Keller <[email protected]> (@RedYetiDev) Branch RedYetiDev:patch-109 -> nodejs:main Labels build, python, needs-ci, android Commits 1 - build: support up to python 3.13 in android-configure Committers 1 - RedYetiDev <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54529 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54529 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: support up to python 3.13 in android-configure ℹ This PR was created on Fri, 23 Aug 2024 21:23:41 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54529#pullrequestreview-2258704668 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/54529#pullrequestreview-2259300306 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54529#pullrequestreview-2259333342 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/54529#pullrequestreview-2259349667 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-18T09:52:04Z: https://ci.nodejs.org/job/node-test-pull-request/62521/ - Querying data for job/node-test-pull-request/62521/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10921686215 |
RedYetiDev
added
the
author ready
|
This needs an approval to land, can someone re-approve? |
jasnell
approved these changes
Sep 21, 2024
jasnell
pushed a commit
that referenced
this pull request
Sep 21, 2024
PR-URL: #54529 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
|
Landed in 415b82d |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54529 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54529 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
marco-ippolito
added
the
backport-requested-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #54358
This PR brings the
android-configurescript up-to-speed with theconfigurescript, that is, supporting python 3.12 and 3.13.