buffer: use simdutf convert_latin1_to_utf8_safe #54798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
|
This need to wait for simdutf 5.5 to land. |
ronag
force-pushed
the
convert_latin1_to_utf8_safe
branch
from
1ba8087
to
8303866
Compare
anonrig
approved these changes
Sep 6, 2024
jasnell
approved these changes
Sep 7, 2024
ronag
added
author ready
github-actions
bot
removed
the
request-ci
ronag
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54798 ✔ Done loading data for nodejs/node/pull/54798 ----------------------------------- PR info ------------------------------------ Title buffer: use simdutf convert_latin1_to_utf8_safe (#54798) Author Robert Nagy <[email protected]> (@ronag) Branch ronag:convert_latin1_to_utf8_safe -> nodejs:main Labels buffer, c++, author ready, needs-ci Commits 1 - buffer: use simdutf convert_latin1_to_utf8_safe Committers 1 - Robert Nagy <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54798 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54798 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 06 Sep 2024 06:24:24 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54798#pullrequestreview-2286222679 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54798#pullrequestreview-2288419791 ✔ - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/54798#pullrequestreview-2288437283 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-09-13T15:59:48Z: https://ci.nodejs.org/job/node-test-pull-request/62411/ - Querying data for job/node-test-pull-request/62411/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10862522075 |
simdutf 5.5 includes convert_latin1_to_utf8_safe
ronag
force-pushed
the
convert_latin1_to_utf8_safe
branch
from
8303866
to
db7ad55
Compare
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54798 +/- ##
==========================================
- Coverage 88.07% 88.07% -0.01%
==========================================
Files 651 651
Lines 183451 183419 -32
Branches 35823 35819 -4
==========================================
- Hits 161574 161545 -29
+ Misses 15133 15132 -1
+ Partials 6744 6742 -2
|
lemire
approved these changes
Sep 15, 2024
|
It's time ⌚ for landing 🛬 |
ronag
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0d4387e |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
simdutf 5.5 includes convert_latin1_to_utf8_safe PR-URL: #54798 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Lemire <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
simdutf 5.5 includes convert_latin1_to_utf8_safe PR-URL: nodejs#54798 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Lemire <[email protected]>
marco-ippolito
added
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simdutf 5.5 includes convert_latin1_to_utf8_safe