cli: ensure --run has proper pwd #54949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
anonrig
added
the
commit-queue-squash
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54949 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.01%
==========================================
Files 651 652 +1
Lines 183538 183589 +51
Branches 35862 35870 +8
==========================================
+ Hits 161647 161675 +28
- Misses 15136 15154 +18
- Partials 6755 6760 +5
|
This comment was marked as outdated.
This comment was marked as outdated.
|
cc @nodejs/cpp-reviewers would you mind reviewing? |
anonrig
requested review from
mcollina,
KhafraDev,
addaleax and
joyeecheung
|
@nodejs/tsc would you mind reviewing this? this pr is the only thing keeping |
KhafraDev
approved these changes
Sep 17, 2024
Don't jinx it. Today is that day @KhafraDev |
anonrig
added
the
author ready
H4ad
approved these changes
Sep 18, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0c5fa57 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54949 Refs: #53600 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54949 Refs: nodejs#53600 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
marco-ippolito
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of @bmeck. I basically rebased and added a new commit applying @huseyinacacak-janea's comments.
Ref: #53600