build,win: float VS 17.11 compilation patch #54970
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
StefanStojanovic
added
windows
anonrig
approved these changes
Sep 16, 2024
anonrig
added
fast-track
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
|
cc @nodejs/build @nodejs/platform-windows |
github-actions
bot
removed
the
request-ci
targos
approved these changes
Sep 16, 2024
richardlau
approved these changes
Sep 16, 2024
RedYetiDev
added
the
author ready
lpinca
approved these changes
Sep 19, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 653b965 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Fixes: #54898 PR-URL: #54970 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
vmoroz
added a commit
to vmoroz/node
that referenced
this pull request
Oct 17, 2024
Fixes: nodejs#54898 PR-URL: nodejs#54970 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> # Conflicts: # deps/ngtcp2/nghttp3/lib/nghttp3_ringbuf.c # deps/ngtcp2/ngtcp2/lib/ngtcp2_ringbuf.c
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Fixes: nodejs#54898 PR-URL: nodejs#54970 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
added
the
backport-requested-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floats dependency patch from ngtcp2/nghttp3#252 to enable updating VS to the latest version (17.11) in the CI.
Fixes: #54898