module: report unfinished TLA in ambiguous modules #54980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
targos
approved these changes
Sep 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54980 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.01%
==========================================
Files 652 652
Lines 183546 183546
Branches 35859 35862 +3
==========================================
- Hits 161649 161639 -10
+ Misses 15147 15145 -2
- Partials 6750 6762 +12
|
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Sep 18, 2024
aduh95
added
the
commit-queue
joyeecheung
approved these changes
Sep 18, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in be4babb |
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Oct 1, 2024
PR-URL: nodejs#54980 Fixes: nodejs#54931 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54980 Fixes: #54931 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54980 Fixes: nodejs#54931 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
marco-ippolito
added
the
backport-blocked-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #54931