Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix mocking modules with quote in their URL #55083

Merged
merged 1 commit into from
Sep 25, 2024
Merged

test_runner: fix mocking modules with quote in their URL #55083

merged 1 commit into from
Sep 25, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 23, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 23, 2024
@RedYetiDev RedYetiDev added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62693/

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (c237eab) to head (8e0ebb7).
Report is 405 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55083      +/-   ##
==========================================
- Coverage   88.26%   88.24%   -0.02%     
==========================================
  Files         652      652              
  Lines      183898   183898              
  Branches    35859    35854       -5     
==========================================
- Hits       162309   162282      -27     
- Misses      14891    14899       +8     
- Partials     6698     6717      +19
Files with missing lines Coverage Δ
lib/internal/test_runner/mock/loader.js 95.52% <100.00%> (ø)

... and 28 files with indirect coverage changes

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit aac8ba7 into nodejs:main Sep 25, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in aac8ba7

@aduh95 aduh95 deleted the mock-module-with-quote branch September 25, 2024 20:09
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
test_runner: fix mocking modules with quote in their URL
7eaeba4 
PR-URL: #55083
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
test_runner: fix mocking modules with quote in their URL
29c7a90 
PR-URL: nodejs#55083
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @bnb @cjihrig @VoltrexKeyva @atlowChemi @marco-ippolito @RedYetiDev