test_runner: close and flush destinations on forced exit #55099
Merged
+74
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
Thanks for tackling this! FWIW LGTM |
RedYetiDev
reviewed
Sep 24, 2024
This commit updates the test runner to explicitly close and flush all destination file streams when the --test-force-exit flag is used. Fixes: nodejs#54327
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55099 +/- ##
==========================================
- Coverage 88.24% 88.24% -0.01%
==========================================
Files 651 651
Lines 183877 183898 +21
Branches 35853 35858 +5
==========================================
+ Hits 162269 162282 +13
- Misses 14899 14903 +4
- Partials 6709 6713 +4
|
atlowChemi
approved these changes
Sep 24, 2024
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
jakecastelli
approved these changes
Sep 26, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e32521a |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
This commit updates the test runner to explicitly close and flush all destination file streams when the --test-force-exit flag is used. Fixes: #54327 PR-URL: #55099 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
This commit updates the test runner to explicitly close and flush all destination file streams when the --test-force-exit flag is used. Fixes: #54327 PR-URL: #55099 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
This commit updates the test runner to explicitly close and flush all destination file streams when the --test-force-exit flag is used. Fixes: nodejs#54327 PR-URL: nodejs#55099 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
marco-ippolito
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the test runner to explicitly close and flush all destination file streams when the
--test-force-exitflag is used.Fixes: #54327