Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: avoid spread operator on arrays #55143

Merged
merged 1 commit into from
Sep 29, 2024
Merged

test_runner: avoid spread operator on arrays #55143

merged 1 commit into from
Sep 29, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 27, 2024

No description provided.

@aduh95 aduh95 requested a review from cjihrig September 27, 2024 15:16
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 27, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (fbc6fcb) to head (979af26).
Report is 358 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/runner.js 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55143   +/-   ##
=======================================
  Coverage   88.23%   88.24%           
=======================================
  Files         651      651           
  Lines      183914   183901   -13     
  Branches    35865    35862    -3     
=======================================
+ Hits       162279   162282    +3     
+ Misses      14910    14904    -6     
+ Partials     6725     6715   -10
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.94% <100.00%> (+<0.01%) ⬆️
lib/internal/test_runner/runner.js 86.75% <33.33%> (-0.10%) ⬇️

... and 20 files with indirect coverage changes

mcollina
mcollina approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62819/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 103b843 into nodejs:main Sep 29, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 103b843

@aduh95 aduh95 deleted the no-spread-on-arrays branch September 29, 2024 17:58
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
test_runner: avoid spread operator on arrays
ab98692 
PR-URL: #55143
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
test_runner: avoid spread operator on arrays
c308862 
PR-URL: #55143
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
test_runner: avoid spread operator on arrays
1adc792 
PR-URL: nodejs#55143
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @mcollina @jasnell @cjihrig @marco-ippolito