tools: add polyfilled option to prefer-primordials rule
#55318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
the
backport-requested-v22.x
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55318 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 652 652
Lines 186796 186759 -37
Branches 36103 36106 +3
=======================================
- Hits 165154 165126 -28
+ Misses 14909 14904 -5
+ Partials 6733 6729 -4 |
targos
approved these changes
Oct 9, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5e5af29 |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 17, 2024
PR-URL: nodejs#55318 Reviewed-By: Michaël Zasso <[email protected]>
aduh95
added a commit
that referenced
this pull request
Oct 19, 2024
PR-URL: #55318 Reviewed-By: Michaël Zasso <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55318 Reviewed-By: Michaël Zasso <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Nov 16, 2024
PR-URL: nodejs#55318 Reviewed-By: Michaël Zasso <[email protected]>
aduh95
added
backport-open-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly relevant for the v22.x branch now that #55276 has landed on
mainand won't land on v22.x. With this change, it's going to make backporting changes to v22.x easier, helping backporters pin point which commits need fixing when backporting to the v22.x staging branch without needing to run the whole test suite.