Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V22.10.0 proposal #55343

Merged
merged 230 commits into from
Oct 16, 2024
Merged

V22.10.0 proposal #55343

merged 230 commits into from
Oct 16, 2024

Commits on Sep 18, 2024

  1. module: fix discrepancy between .ts and .js

    PR-URL: #54461
    Backport-PR-URL: #54566
    Fixes: #54457
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    marco-ippolito committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    67ecb10 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. deps: V8: cherry-pick 217457d0a560

    Original commit message:
    
        [set-methods] Handle SetLike with infinite size
    
        This CL adds a check for identifying SetLikes with infinite sizes in
        methods dependent on the size of `other`s.
    
        Bug: 351332634
        Change-Id: I5c6d9c0cc7f3f5fae5cedc72a44bc21c917c84b8
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5684652
        Reviewed-by: Shu-yu Guo <[email protected]>
        Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#94897}
    
    Refs: v8/v8@217457d
    PR-URL: #54883
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    targos committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1de5512 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. doc: add documentation for process.features

    PR-URL: #54897
    Refs: #54295
    Reviewed-By: Ethan Arrowood <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    marco-ippolito authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    eca9668 View commit details
    Browse the repository at this point in the history
  2. doc: update documentation for externalizing deps

    Refs: #54646
    
    - Add instructions to update how process.versions is reported
      as I missed that in a recent addition.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #54792
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Akhil Marsonya <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c1d73ab View commit details
    Browse the repository at this point in the history
  3. doc: fix typo callsite.lineNumber

    PR-URL: #54969
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RafaelGSS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    29866ca View commit details
    Browse the repository at this point in the history
  4. src: use Maybe<void> where bool isn't needed

    PR-URL: #54575
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f332c4c View commit details
    Browse the repository at this point in the history
  5. tools: update github_reporter to 1.7.1

    PR-URL: #54951
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    676d0a0 View commit details
    Browse the repository at this point in the history
  6. module: remove bogus assertion in CJS entrypoint handling with --import

    The synchronous CJS translator can handle entrypoints now, this
    can be hit when --import is used, so lift the bogus assertions and
    added tests.
    
    PR-URL: #54592
    Fixes: #54577
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    108cef2 View commit details
    Browse the repository at this point in the history
  7. deps: update corepack to 0.29.4

    PR-URL: #54845
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0d45365 View commit details
    Browse the repository at this point in the history
  8. doc: fix history of process.features

    PR-URL: #54982
    Refs: aa0308d
    Refs: 9010f5f
    Refs: 52a40e0
    Refs: b3ef289
    Refs: #2564
    Refs: #25819
    Refs: #27311
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f2d74a2 View commit details
    Browse the repository at this point in the history
  9. lib: the REPL should survive deletion of Array.prototype methods

    Specifically, `delete Array.prototype.lastIndexOf` immediately crashes
    the REPL, as does deletion of a few other Array prototype methods.
    
    PR-URL: #31457
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    ljharb authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    397ae41 View commit details
    Browse the repository at this point in the history
  10. module: refator ESM loader for adding future synchronous hooks

    This lays the foundation for supporting synchronous hooks proposed
    in nodejs/loaders#198 for ESM.
    
    - Corrects and adds several JSDoc comments for internal functions
      of the ESM loader, as well as explaining how require() for
      import CJS work in the special resolve/load paths. This doesn't
      consolidate it with import in require(esm) yet due to caching
      differences, which is left as a TODO.
    - The moduleProvider passed into ModuleJob is replaced as
      moduleOrModulePromise, we call the translators directly in the
      ESM loader and verify it right after loading for clarity.
    - Reuse a few refactored out helpers for require(esm) in
      getModuleJobForRequire().
    
    PR-URL: #54769
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c89c934 View commit details
    Browse the repository at this point in the history
  11. benchmark: add dotenv benchmark

    PR-URL: #54278
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    23b628d View commit details
    Browse the repository at this point in the history
  12. crypto: add Date fields for validTo and validFrom

    Added equivalent fields to `X509Certificate` in Date form.
    
    PR-URL: #54159
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tim Perry <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    RulerOfCakes authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    349d2ed View commit details
    Browse the repository at this point in the history
  13. os: use const with early return for path

    PR-URL: #54959
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    trivikr authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3300d59 View commit details
    Browse the repository at this point in the history
  14. meta: add links to alternative issue trackers

    PR-URL: #54401
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ca67c97 View commit details
    Browse the repository at this point in the history
  15. doc: add missing definitions to internal-api.md

    PR-URL: #53303
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3a5fe95 View commit details
    Browse the repository at this point in the history
  16. meta: remove build-windows.yml

    PR-URL: #54662
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Stefan Stojanovic <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ce0d0c1 View commit details
    Browse the repository at this point in the history
  17. doc: change backporting guide with updated info

    PR-URL: #53746
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    39a728c View commit details
    Browse the repository at this point in the history
  18. cli: fix spacing for port range error

    PR-URL: #54495
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a97841e View commit details
    Browse the repository at this point in the history
  19. build: print Running XYZ linter... for py and yml

    PR-URL: #54386
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7861ca5 View commit details
    Browse the repository at this point in the history
  20. src: remove duplicate code setting AF_INET

    `AF_INET` has been repeatedly set three times in the code. this should
    be redundant. removed the last two times.
    
    PR-URL: #54939
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    kernelbin authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    284db53 View commit details
    Browse the repository at this point in the history
  21. path: remove repetitive conditional operator in posix.resolve

    PR-URL: #54835
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    HBSPS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    90cce6e View commit details
    Browse the repository at this point in the history
  22. cli: ensure --run has proper pwd

    PR-URL: #54949
    Refs: #53600
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    048a1ab View commit details
    Browse the repository at this point in the history
  23. meta: remove unneeded ignore rules from ruff

    PR-URL: #54360
    Reviewed-By: Christian Clauss <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e1f36d0 View commit details
    Browse the repository at this point in the history
  24. events: return currentTarget when dispatching

    PR-URL: #54642
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Mattias Buelens <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    KhafraDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cb47e16 View commit details
    Browse the repository at this point in the history
  25. test: update DOM events web platform tests

    PR-URL: #54642
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Mattias Buelens <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    KhafraDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9b78345 View commit details
    Browse the repository at this point in the history
  26. Revert "build: upgrade clang-format to v18"

    This reverts commit c3e1c31.
    
    PR-URL: #54994
    Refs: #53957
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    legendecas authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c8b7a64 View commit details
    Browse the repository at this point in the history
  27. test_runner: avoid coverage report partial file names

    Co-author: Medhansh404 <[email protected]>
    PR-URL: #54379
    Fixes: #51299
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    pmarchini authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1daec9a View commit details
    Browse the repository at this point in the history
  28. test: update test to support OpenSSL32

    Refs: #53382
    
    This test fails on OpenSSL32 because it complains the key being
    used is too short.
    
    It seems to have been missed when the test suite was udpated to have
    a Makefile to generate key material as the keys are hard coded in the
    test as opposed to being read in from the fixtures/key directory.
    
    Update the test to use keys/certs from the fixtures directory and
    to remove newlines at the end of the key and cert to retain the
    inteded test.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #54968
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    90a87ca View commit details
    Browse the repository at this point in the history
  29. buffer: use simdutf convert_latin1_to_utf8_safe

    simdutf 5.5 includes convert_latin1_to_utf8_safe
    
    PR-URL: #54798
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Daniel Lemire <[email protected]>
    ronag authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d109f1c View commit details
    Browse the repository at this point in the history
  30. test: adjust key sizes to support OpenSSL32

    Refs: #53382
    
    This test fails on OpenSSL32 because it complains the key
    being used is too short.
    
    Adjust the key sizes so that they will pass on OpenSSL32 in
    addition to other OpenSSL3 versions.
    
    Since the keys are not public key related I don't think the
    increase in key size will be too bad in terms of performance so
    I've just increased versus guarding for OpenSSL32
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #54972
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1f11d68 View commit details
    Browse the repository at this point in the history
  31. tools: bump the eslint group in /tools/eslint with 7 updates

    Bumps the eslint group in /tools/eslint with 7 updates:
    
    | Package | From | To |
    | --- | --- | --- |
    | `@babel/core` | `7.24.9` | `7.25.2` |
    | `@babel/eslint-parser` | `7.25.0` | `7.25.1` |
    | `@babel/plugin-syntax-import-attributes` | `7.24.7` | `7.25.6` |
    | `@stylistic/eslint-plugin-js` | `2.4.0` | `2.7.2` |
    | `eslint` | `9.8.0` | `9.9.1` |
    | `eslint-plugin-jsdoc` | `48.8.3` | `50.2.2` |
    | `globals` | `15.8.0` | `15.9.0` |
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #54821
    Reviewed-By: Antoine du Hamel <[email protected]>
    dependabot[bot] authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    31f0ef6 View commit details
    Browse the repository at this point in the history
  32. zlib: remove prototype primordials usage

    # Conflicts:
    #	lib/zlib.js
    
    PR-URL: #54695
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9abd1c7 View commit details
    Browse the repository at this point in the history
  33. worker: handle --input-type more consistently

    PR-URL: #54979
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fc90d7c View commit details
    Browse the repository at this point in the history
  34. module: report unfinished TLA in ambiguous modules

    PR-URL: #54980
    Fixes: #54931
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1d16976 View commit details
    Browse the repository at this point in the history
  35. test_runner: support typescript module mocking

    PR-URL: #54878
    Fixes: #54428
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Erick Wendel <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    marco-ippolito authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    93c6c90 View commit details
    Browse the repository at this point in the history
  36. meta: remove never-used workflow trigger

    PR-URL: #54983
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4fb2c3b View commit details
    Browse the repository at this point in the history
  37. test: refactor test-whatwg-webstreams-encoding to be shorter

    PR-URL: #54569
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    hidaviddong authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    62b8640 View commit details
    Browse the repository at this point in the history
  38. tools: refactor js2c.cc to use c++20

    PR-URL: #54849
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Daniel Lemire <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ce4b6e4 View commit details
    Browse the repository at this point in the history
  39. benchmark: include ascii to fs/readfile

    PR-URL: #54988
    Reviewed-By: Daniel Lemire <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    RafaelGSS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d4d5ba3 View commit details
    Browse the repository at this point in the history
  40. build,win: float VS 17.11 compilation patch

    Fixes: #54898
    PR-URL: #54970
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    StefanStojanovic authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    30d4722 View commit details
    Browse the repository at this point in the history
  41. test: remove test-http-max-sockets flaky designation

    There is no recent trace of failure for this test.
    
    Fixes: #47116
    PR-URL: #54976
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    lpinca authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    22b4139 View commit details
    Browse the repository at this point in the history
  42. test: move test-http-max-sockets to parallel

    PR-URL: #54977
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    lpinca authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5b012f5 View commit details
    Browse the repository at this point in the history
  43. test: fix invalid wasm test

    PR-URL: #54935
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    327a8f7 View commit details
    Browse the repository at this point in the history
  44. doc: add more details for localStorage and sessionStorage

    PR-URL: #53881
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Rekl0w authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4244f1a View commit details
    Browse the repository at this point in the history
  45. test_runner: add support for coverage via run()

    PR-URL: #53937
    Fixes: #53867
    Refs: #53924
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    atlowChemi authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d7c708a View commit details
    Browse the repository at this point in the history
  46. test: add runner watch mode isolation tests

    PR-URL: #54888
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    pmarchini authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    98ff615 View commit details
    Browse the repository at this point in the history
  47. src: add unistd.h import if node posix credentials is defined

    usage comment
    
    PR-URL: #54528
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    JonasBa authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0876f78 View commit details
    Browse the repository at this point in the history
  48. module: write compile cache to temporary file and then rename it

    This works better in terms of avoiding race conditions.
    
    PR-URL: #54971
    Fixes: #54770
    Fixes: #54465
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f9b19d7 View commit details
    Browse the repository at this point in the history
  49. module: throw when invalid argument is passed to enableCompileCache()

    PR-URL: #54971
    Fixes: #54770
    Fixes: #54465
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2dcf70c View commit details
    Browse the repository at this point in the history
  50. module: implement flushCompileCache()

    This implements an API for users to intentionally flush the
    accumulated compile cache instead of waiting until process
    shutdown. It may be useful for application that loads dependencies
    first and then either reload itself in other instances, or spawning
    other instances that load an overlapping set of its dependencies -
    in this case its useful to flush the cache early instead of waiting
    until the shutdown of itself.
    
    Currently flushing is triggered by either process
    shutdown or user requests. In the future we should simply start the
    writes right after module loading on a separate thread, and this method
    only blocks until all the pending writes (if any) on the other thread
    are finished. In that case, the off-thread writes should finish long
    before any attempt of flushing is made so the method would then only
    incur a negligible overhead from thread synchronization.
    
    PR-URL: #54971
    Fixes: #54770
    Fixes: #54465
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    06957ff View commit details
    Browse the repository at this point in the history
  51. src: cleanup per env handles directly without a list

    Environment handles can be cleaned up directly without saving the
    references in a list and iterate the list.
    
    PR-URL: #54993
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    legendecas authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ef546c8 View commit details
    Browse the repository at this point in the history
  52. build: fix eslint makefile target

    PR-URL: #54999
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a81f368 View commit details
    Browse the repository at this point in the history
  53. test: add asserts to validate test assumptions

    Refs: #54968
    Refs: #53382
    
    Add additional asserts as suggestd by Richard in:
    #54968
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #54997
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6843ca7 View commit details
    Browse the repository at this point in the history
  54. test: fix soucre to source

    PR-URL: #55038
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1e53c10 View commit details
    Browse the repository at this point in the history
  55. test_runner: replace ansi clear with ansi reset

    PR-URL: #55013
    Fixes: #55009
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    pmarchini authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4b962a7 View commit details
    Browse the repository at this point in the history
  56. tools: update error message for ICU in license-builder

    PR-URL: #54742
    Reviewed-By: Steven R Loomis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    295f684 View commit details
    Browse the repository at this point in the history
  57. build: add the option to generate compile_commands.json in vcbuild.bat

    Refs: nodejs/gyp-next#238
    PR-URL: #52279
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Stefan Stojanovic <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    segevfiner authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a929c71 View commit details
    Browse the repository at this point in the history
  58. test: deflake test-http-header-overflow

    Skip the network and push the data directly to the receiving socket
    so that it is guaranteed to be received as a single chunk.
    
    Fixes: #46291
    PR-URL: #54978
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lpinca authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    341b6d9 View commit details
    Browse the repository at this point in the history
  59. lib: propagate aborted state to dependent signals before firing events

    PR-URL: #54826
    Fixes: #54466
    Fixes: #54601
    Reviewed-By: James M Snell <[email protected]>
    jazelly authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f7c3b03 View commit details
    Browse the repository at this point in the history
  60. events: allow null/undefined eventInitDict

    PR-URL: #54643
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    KhafraDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    be2fe4b View commit details
    Browse the repository at this point in the history
  61. test: remove unused common utilities

    PR-URL: #54825
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    20d3a80 View commit details
    Browse the repository at this point in the history
  62. fs: convert to u8 string for filesystem path

    PR-URL: #54653
    Fixes: #54476
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    jazelly authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    79ffefa View commit details
    Browse the repository at this point in the history
  63. test: remove getCallSite from common

    PR-URL: #54947
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9506f77 View commit details
    Browse the repository at this point in the history
  64. build: support up to python 3.13 in android-configure

    PR-URL: #54529
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3077f6a View commit details
    Browse the repository at this point in the history
  65. test: improve coverage for timer promises schedular

    PR-URL: #53370
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a679669 View commit details
    Browse the repository at this point in the history
  66. zlib: throw brotli initialization error from c++

    PR-URL: #54698
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a9fa2da View commit details
    Browse the repository at this point in the history
  67. util: update ansi regex

    PR-URL: #54865
    Refs: chalk/ansi-regex#58
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d264639 View commit details
    Browse the repository at this point in the history
  68. test: add util.stripVTControlCharacters test

    PR-URL: #54865
    Refs: chalk/ansi-regex#58
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    22e601a View commit details
    Browse the repository at this point in the history
  69. src: mark node --run as stable

    PR-URL: #53763
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    465d050 View commit details
    Browse the repository at this point in the history
  70. test_runner: use test: symbol on second print of parent test

    PR-URL: #54956
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    449dad0 View commit details
    Browse the repository at this point in the history
  71. src: revert filesystem::path changes

    PR-URL: #55015
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9ae80e1 View commit details
    Browse the repository at this point in the history
  72. test_runner: add 'test:summary' event

    This commit adds a new 'test:summary' event to the test runner's
    reporting interface. This new event serves two purposes:
    
    - In the future, the test runner internals will no longer need to
      change the process exit code. This may be important to run()
      users. Unfortunately, this is a breaking change, so it needs to
      be changed in a major version.
    - The reporting interface now has a single event that can identify
      passing or failing test runs.
    
    Refs: #53867
    Refs: #54812
    PR-URL: #54851
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    cjihrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b62f2f8 View commit details
    Browse the repository at this point in the history
  73. test: adjust tls-set-ciphers for OpenSSL32

    Refs: #53382
    
    The test failed as it was using AES128 which is not supported
    in OpenSSL32 due to default security level and because
    some error messages have changed.
    
    Adjusted to use AES256 where it made sense and not run
    tests on OpenSSL32 where test was specific to AES128.
    
    Adjust to use the expected error messages based on version.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #55016
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6d42e44 View commit details
    Browse the repository at this point in the history
  74. doc: cover --experimental-test-module-mocks flag

    PR-URL: #55021
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    textbook authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    516c775 View commit details
    Browse the repository at this point in the history
  75. doc: add missing EventSource docs to globals

    PR-URL: #55022
    Refs: #51575
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    KhafraDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b3e0490 View commit details
    Browse the repository at this point in the history
  76. meta: add linux to OS labels in collaborator guide

    PR-URL: #54986
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    aeae597 View commit details
    Browse the repository at this point in the history
  77. module: remove duplicated import

    PR-URL: #54942
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b6fc9ad View commit details
    Browse the repository at this point in the history
  78. test: fix test-vm-context-dont-contextify when path contains a space

    Because of the double encoding, the test would fail as soon as the path
    contains a space or any other char that's already encoded by
    `pathToFileURL`.
    
    PR-URL: #55026
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c56e324 View commit details
    Browse the repository at this point in the history
  79. test: do not assume process.execPath contains no spaces

    We had a bunch of tests that would fail if run from an executable that
    contains any char that should be escaped when run from a shell.
    
    PR-URL: #55028
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a50dd21 View commit details
    Browse the repository at this point in the history
  80. test,crypto: update WebCryptoAPI WPT

    PR-URL: #55029
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    panva authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1c00155 View commit details
    Browse the repository at this point in the history
  81. test: update tls test to support OpenSSL32

    Refs: #53382
    
    OpenSSL32 does not support AES128 and DH 1024 to
    update test to use newer algorithms.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #55030
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    268f1ec View commit details
    Browse the repository at this point in the history
  82. doc: remove parseREPLKeyword from REPL documentation

    PR-URL: #54749
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    89aeae6 View commit details
    Browse the repository at this point in the history
  83. test: make test-runner-assert more robust

    PR-URL: #55036
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    43bbca2 View commit details
    Browse the repository at this point in the history
  84. test_runner: report error on missing sourcemap source

    Co-Authored-By: Jayden Seric <[email protected]>
    Co-Authored-By: Colin Ihrig <[email protected]>
    PR-URL: #55037
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    3 people authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8818c6c View commit details
    Browse the repository at this point in the history
  85. build: display free disk space after build in the test-macOS workflow

    PR-URL: #55025
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    iwuliz authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d3dfbe7 View commit details
    Browse the repository at this point in the history
  86. build: remove -v flag to reduce noise

    PR-URL: #55025
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    iwuliz authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d99ae54 View commit details
    Browse the repository at this point in the history
  87. src: move evp stuff to ncrypto

    PR-URL: #54911
    Reviewed-By: Yagiz Nizipli <[email protected]>
    jasnell authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3a1485a View commit details
    Browse the repository at this point in the history
  88. benchmark: add webstorage benchmark

    PR-URL: #55040
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    jakecastelli authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    452bc9b View commit details
    Browse the repository at this point in the history
  89. crypto: ensure invalid SubtleCrypto JWK data import results in DataError

    PR-URL: #55041
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    panva authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d3f8c35 View commit details
    Browse the repository at this point in the history
  90. lib: remove lib/internal/idna.js

    PR-URL: #55050
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d4873bc View commit details
    Browse the repository at this point in the history
  91. doc: add note about --expose-internals

    PR-URL: #52861
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a97c80c View commit details
    Browse the repository at this point in the history
  92. tools: remove redudant code from eslint require rule

    PR-URL: #54892
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    65c376a View commit details
    Browse the repository at this point in the history
  93. test: deflake test-inspector-strip-types

    Use the `NodeRuntime.waitingForDebugger` event.
    
    Refs: #51560
    PR-URL: #55058
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    lpinca authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    93c23e7 View commit details
    Browse the repository at this point in the history
  94. deps: update acorn-walk to 8.3.4

    PR-URL: #54950
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    173464d View commit details
    Browse the repository at this point in the history
  95. test: remove interval and give more time to unsync

    PR-URL: #55006
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    pmarchini authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    80da599 View commit details
    Browse the repository at this point in the history
  96. build: update ruff and add lint-py-fix

    PR-URL: #54410
    Reviewed-By: Christian Clauss <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f3ca9c6 View commit details
    Browse the repository at this point in the history
  97. doc: add abmusse to collaborators

    PR-URL: #55086
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    abmusse authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bebc95e View commit details
    Browse the repository at this point in the history
  98. perf_hooks: add missing type argument to getEntriesByName

    Fixes: #54766
    PR-URL: #54767
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    luketaher authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cbfc980 View commit details
    Browse the repository at this point in the history
  99. lib: prefer optional chaining

    PR-URL: #55045
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d803355 View commit details
    Browse the repository at this point in the history
  100. tty: fix links for terminal colors

    PR-URL: #54596
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0f01f38 View commit details
    Browse the repository at this point in the history
  101. build: add more information to Makefile help

    PR-URL: #53381
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    68822cc View commit details
    Browse the repository at this point in the history
  102. tools: unlock versions of irrelevant DB deps

    This essentially reverts e0e0b1a.
    
    We don't bundle ESLint anymore, so the change is no longer needed.
    
    PR-URL: #55042
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3304bf3 View commit details
    Browse the repository at this point in the history
  103. stream: set stream prototype to closest transferable superclass

    PR-URL: #55067
    Fixes: #54603
    Refs: #50107
    Reviewed-By: Mattias Buelens <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    jazelly authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bf69ae1 View commit details
    Browse the repository at this point in the history
  104. module: implement the "module-sync" exports condition

    This patch implements a "module-sync" exports condition
    for packages to supply a sycnrhonous ES module to the
    Node.js module loader, no matter it's being required
    or imported. This is similar to the "module" condition
    that bundlers have been using to support `require(esm)`
    in Node.js, and allows dual-package authors to opt into
    ESM-first only newer versions of Node.js that supports
    require(esm) while avoiding the dual-package hazard.
    
    ```json
    {
      "type": "module",
      "exports": {
        "node": {
          // On new version of Node.js, both require() and import get
          // the ESM version
          "module-sync": "./index.js",
          // On older version of Node.js, where "module" and
          // require(esm) are not supported, use the transpiled CJS version
          // to avoid dual-package hazard. Library authors can decide
          // to drop support for older versions of Node.js when they think
          // it's time.
          "default": "./dist/index.cjs"
        },
        // On any other environment, use the ESM version.
        "default": "./index.js"
      }
    }
    ```
    
    We end up implementing a condition with a different name
    instead of reusing "module", because existing code in the
    ecosystem using the "module" condition sometimes also expect
    the module resolution for these ESM files to work in CJS
    style, which is supported by bundlers, but the native
    Node.js loader has intentionally made ESM resolution
    different from CJS resolution (e.g. forbidding `import
    './noext'` or `import './directory'`), so it would be
    semver-major to implement a `"module"` condition
    without implementing the forbidden ESM resolution rules.
    For now, this just implments a new condition as semver-minor
    so it can be backported to older LTS.
    
    Refs: https://webpack.js.org/guides/package-exports/#target-environment-independent-packages
    PR-URL: #54648
    Fixes: #52173
    Refs: https://github.com/joyeecheung/test-module-condition
    Refs: #52697
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    111261e View commit details
    Browse the repository at this point in the history
  105. repl: catch \v and \r in new-line detection

    PR-URL: #54512
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    538b1eb View commit details
    Browse the repository at this point in the history
  106. lib, tools: remove duplicate requires

    PR-URL: #54987
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    566179c View commit details
    Browse the repository at this point in the history
  107. Revert "test: mark test-fs-watch-non-recursive flaky on Windows"

    This reverts commit 2a871df.
    
    It has been almost three years since the test was marked flaky. Remove
    the unstable designation to see if the problem persists on Windows.
    
    Fixes: #40728
    PR-URL: #55079
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Stefan Stojanovic <[email protected]>
    lpinca authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    36c9ea8 View commit details
    Browse the repository at this point in the history
  108. doc: correct cleanup option in stream.(promises.)finished

    PR-URL: #55043
    Refs: #44862
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Renegade334 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    73b05cf View commit details
    Browse the repository at this point in the history
  109. lib: fix typos

    PR-URL: #55065
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    NathanBaulch authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bf7d7ae View commit details
    Browse the repository at this point in the history
  110. src: update clang-tidy and focus on modernization

    PR-URL: #53757
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1fc8ede View commit details
    Browse the repository at this point in the history
  111. benchmark: create benchmark for typescript

    PR-URL: #54904
    Reviewed-By: Matteo Collina <[email protected]>
    marco-ippolito authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4352d9c View commit details
    Browse the repository at this point in the history
  112. test: fix some tests when path contains %

    Tests should pass even if the path where the repo is cloned contains
    URL-significant chars.
    
    PR-URL: #55082
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fdae57f View commit details
    Browse the repository at this point in the history
  113. test_runner: fix mocking modules with quote in their URL

    PR-URL: #55083
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7eaeba4 View commit details
    Browse the repository at this point in the history
  114. meta: add more information about nightly releases

    PR-URL: #55084
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    93b215d View commit details
    Browse the repository at this point in the history
  115. test: fix assertSnapshot when path contains a quote

    PR-URL: #55087
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    85f1187 View commit details
    Browse the repository at this point in the history
  116. test: fix more tests that fail when path contains a space

    PR-URL: #55088
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b885f05 View commit details
    Browse the repository at this point in the history
  117. test: fix test-tls-junk-closes-server

    Refs: #53382
    
    TLS spec seems to indicate there should should be a response
    sent when TLS handshake fails. See
    https://datatracker.ietf.org/doc/html/rfc8446#page-85
    
    When compiled with OpenSSL32 we see the
    the following response '15 03 03 00 02 02 16' which
    decodes as a fatal (0x02) TLS error alert number 22 (0x16).
    which corresponds to TLS1_AD_RECORD_OVERFLOW which matches
    the error we see if NODE_DEBUG is turned on once you get
    through the define aliases.
    
    If there is a response from the server the test used to
    hang because the end event will not be emitted until after
    the response is consumed. This PR fixes the test so
    it consumes the response.
    
    Some earlier OpenSSL versions did not seem to send a response but
    the error handling seems to have been re-written/improved
    in OpenSSL32.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #55089
    Refs: #52482
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Jithil P Ponnan <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e879c5e View commit details
    Browse the repository at this point in the history
  118. src: decode native error messages as UTF-8

    The native error messages can sometimes contain e.g. path content
    that are typically passed in as chars with UTF8-encoded code points.
    The native error throwing code previously always decode the chars
    as Latin-1, which would be incorrect.
    
    PR-URL: #55024
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ee0a98b View commit details
    Browse the repository at this point in the history
  119. test: deflake test-http-remove-header-stays-removed

    Instead of relying on a timer, verify that `socket.end()` is called when
    the `'finish'` event is emitted on the `ServerResponse` object.
    
    PR-URL: #55004
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    lpinca authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fb8470a View commit details
    Browse the repository at this point in the history
  120. buffer: extract Blob's .arrayBuffer() & webidl changes

    - Extracts Blob.prototype.arrayBuffer so it cannot be
      overridden in .text(), etc.
    - Make .bytes() enumerable. I guess the WPT runner is
      not running the idlharness tests?
    - Make .text() return a Promise, rather than being
      explicitly async. This is a non-documented part of
      the webidl spec. Refs: #49936
    - Have .text(), .arrayBuffer(), and .bytes() reject
      for an invalid this instead of throwing. Fix the
      tests regarding this.
    
    PR-URL: #53372
    Refs: #49936
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    KhafraDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3a6e724 View commit details
    Browse the repository at this point in the history
  121. deps: update timezone to 2024b

    PR-URL: #55056
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b0636a1 View commit details
    Browse the repository at this point in the history
  122. tools: bump Rollup from 4.18.1 to 4.22.4 for lint-md

    Bumps [rollup](https://github.com/rollup/rollup) from 4.18.1 to 4.22.4.
    - [Release notes](https://github.com/rollup/rollup/releases)
    - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
    - [Commits](rollup/rollup@v4.18.1...v4.22.4)
    
    ---
    updated-dependencies:
    - dependency-name: rollup
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #55093
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    dependabot[bot] authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b7b1fa6 View commit details
    Browse the repository at this point in the history
  123. doc: add missing : to run()'s globPatterns

    PR-URL: #55135
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    12c9d97 View commit details
    Browse the repository at this point in the history
  124. src: move more stuff over to use Maybe<void>

    PR-URL: #54831
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    jasnell authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a96d5d1 View commit details
    Browse the repository at this point in the history
  125. doc: update style guide

    PR-URL: #53223
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fd40f08 View commit details
    Browse the repository at this point in the history
  126. test: deflake test/pummel/test-timers.js

    PR-URL: #55098
    Fixes: #55092
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    jakecastelli authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e99d4a4 View commit details
    Browse the repository at this point in the history
  127. module: support loading entrypoint as url

    Co-Authored-By: Antoine du Hamel <[email protected]>
    PR-URL: #54933
    Refs: #49975
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    2 people authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    32261fc View commit details
    Browse the repository at this point in the history
  128. test: remove duplicated test descriptions

    PR-URL: #54140
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    unseen1980 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0999b5e View commit details
    Browse the repository at this point in the history
  129. esm: do not interpret "main" as a URL

    As documented, its value is a path.
    
    PR-URL: #55003
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0fb446e View commit details
    Browse the repository at this point in the history
  130. stream: treat null asyncIterator as undefined

    According to the spec, getIterator should normalize incoming method to
    undefined if it is either undefined or null. This PR enforces that spec
    compliance with passed WPT.
    
    PR-URL: #55119
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Mattias Buelens <[email protected]>
    jazelly authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a9675a0 View commit details
    Browse the repository at this point in the history
  131. doc: fix the require resolve algorithm in modules.md

    Before the fix, the pseudocode was describing an infinite loop.
    
    PR-URL: #55117
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    chirsz-ever authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8ad0dff View commit details
    Browse the repository at this point in the history
  132. src: fix typos

    PR-URL: #55064
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    NathanBaulch authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    706e961 View commit details
    Browse the repository at this point in the history
  133. build: notify via slack when review-wanted

    I have noticed we don't have a usual workflow for
    review-wanted PRs. So, in other words the label
    is not useful as it should be. This commit notify
    via Slack (#node-core) whenever this label is placed
    either on an issue or in a PR.
    
    PR-URL: #55102
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    RafaelGSS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d7a9df6 View commit details
    Browse the repository at this point in the history
  134. doc: put --env-file-if-exists=config right under --env-file=config

    PR-URL: #55131
    Fixes: #55129
    Refs: #53060
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    geeksilva97 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7186ede View commit details
    Browse the repository at this point in the history
  135. src: add receiver to fast api callback methods

    When creating an fast api the callback might use the receiver. In that
    case if the internal binding is destructured the method won't have
    access to the reciver and it will throw. Passing the receiver as second
    argument ensures the receiver is available.
    
    PR-URL: #54408
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Santiago Gimeno <[email protected]>
    Ceres6 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0bb5584 View commit details
    Browse the repository at this point in the history
  136. doc: remove random horizontal separators in process.md

    PR-URL: #55149
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b12b4a2 View commit details
    Browse the repository at this point in the history
  137. tools: make choco install script more readable

    PR-URL: #54002
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Stefan Stojanovic <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    60a35ed View commit details
    Browse the repository at this point in the history
  138. Revert "console: colorize console error and warn"

    This reverts commit a833c9e.
    
    PR-URL: #54677
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1dcc5ee View commit details
    Browse the repository at this point in the history
  139. fs: check subdir correctly in cpSync

    PR-URL: #55033
    Fixes: #54285
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    jazelly authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1c94725 View commit details
    Browse the repository at this point in the history
  140. doc: move the YAML changes element

    moved YAML changes element regarding to `onread` option
    from `socket.connect(options[, connectListener])`
    to `new net.Socket([options])`
    
    PR-URL: #55112
    Refs: #25436
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    sendoru authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6cc4951 View commit details
    Browse the repository at this point in the history
  141. test_runner: support custom arguments in run()

    PR-URL: #55126
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    86f7cb8 View commit details
    Browse the repository at this point in the history
  142. test: fix typos

    PR-URL: #55063
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    NathanBaulch authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9aeba48 View commit details
    Browse the repository at this point in the history
  143. test_runner: close and flush destinations on forced exit

    This commit updates the test runner to explicitly close and flush
    all destination file streams when the --test-force-exit flag is
    used.
    
    Fixes: #54327
    PR-URL: #55099
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    cjihrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    19cfa31 View commit details
    Browse the repository at this point in the history
  144. doc: remove outdated https import reference

    PR-URL: #55111
    Fixes: #55091
    Refs: #53822
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    geeksilva97 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bb34990 View commit details
    Browse the repository at this point in the history
  145. assert: show the diff when deep comparing data with a custom message

    Fixes: #48465
    PR-URL: #54759
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    puskin94 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e361951 View commit details
    Browse the repository at this point in the history
  146. doc: add esm examples to node:net

    PR-URL: #55134
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    mfdebian authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    61b9ed3 View commit details
    Browse the repository at this point in the history
  147. src: move more key handling to ncrypto

    PR-URL: #55108
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    jasnell authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    942ad54 View commit details
    Browse the repository at this point in the history
  148. tools: only check teams on the default branch

    PR-URL: #55124
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7982d3d View commit details
    Browse the repository at this point in the history
  149. test_runner: support typescript files in default glob

    PR-URL: #55081
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1240197 View commit details
    Browse the repository at this point in the history
  150. buffer: coerce extrema to int in blob.slice

    PR-URL: #55141
    Fixes: #55139
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b1ebb0d View commit details
    Browse the repository at this point in the history
  151. test: remove unnecessary await in test-watch-mode

    PR-URL: #55142
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    iwuliz authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cc88382 View commit details
    Browse the repository at this point in the history
  152. test_runner: avoid spread operator on arrays

    PR-URL: #55143
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c308862 View commit details
    Browse the repository at this point in the history
  153. test: add escapePOSIXShell util

    PR-URL: #55125
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    65fbe94 View commit details
    Browse the repository at this point in the history
  154. doc: fix link in test/README.md

    PR-URL: #55165
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    LiviaMedeiros authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    781ffd8 View commit details
    Browse the repository at this point in the history
  155. http2: expose nghttp2_option_set_stream_reset_rate_limit as an option

    PR-URL: #54875
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    arcanis authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    914db60 View commit details
    Browse the repository at this point in the history
  156. test: update wpt test for encoding

    PR-URL: #55151
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Nahee-Park authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a57c8ba View commit details
    Browse the repository at this point in the history
  157. src: parse --stack-trace-limit and use it in --trace-* flags

    Previously, --trace-exit and --trace-sync-io doesn't take care
    of --stack-trace-limit and always print a stack trace with maximum
    size of 10. This patch parses --stack-trace-limit during
    initialization and use the value in --trace-* flags.
    
    PR-URL: #55121
    Fixes: #55100
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b229083 View commit details
    Browse the repository at this point in the history
  158. src: fixup Error.stackTraceLimit during snapshot building

    When V8 creates a context for snapshot building, it does not
    install Error.stackTraceLimit. As a result, error.stack would
    be undefined in the snapshot builder script unless users
    explicitly initialize Error.stackTraceLimit, which may be
    surprising.
    
    This patch initializes Error.stackTraceLimit based on the
    value of --stack-trace-limit to prevent the surprise. If
    users have modified Error.stackTraceLimit in the builder
    script, the modified value would be restored during
    deserialization. Otherwise, the fixed up limit would be
    deleted since V8 expects to find it unset and re-initialize
    it during snapshot deserialization.
    
    PR-URL: #55121
    Fixes: #55100
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    joyeecheung authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1af5ad6 View commit details
    Browse the repository at this point in the history
  159. build,win: add winget config to set up env

    PR-URL: #54729
    Reviewed-By: Stefan Stojanovic <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    huseyinacacak-janea authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    aaea394 View commit details
    Browse the repository at this point in the history
  160. stream: handle undefined chunks correctly in decode stream

    Align TextDecoderStream behavior with WPT requirements by treating
    undefined chunks as errors. This change ensures that TextDecoderStream
    properly handles unexpected chunk types and throws an error when
    receiving undefined input.
    
    This update addresses the failing WPT for decode stream error handling.
    
    PR-URL: #55153
    Reviewed-By: Mattias Buelens <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Nahee-Park authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c7ed2ff View commit details
    Browse the repository at this point in the history
  161. src: modernize likely/unlikely hints

    PR-URL: #55155
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    anonrig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d6bcc44 View commit details
    Browse the repository at this point in the history
  162. benchmark: add no-warnings to process.has bench

    PR-URL: #55159
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    RafaelGSS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    cd0795f View commit details
    Browse the repository at this point in the history
  163. watch: preserve output when gracefully restarted

    PR-URL: #54323
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    theoludwig authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fa695fa View commit details
    Browse the repository at this point in the history
  164. meta: add mailmap entry for abmusse

    PR-URL: #55182
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    abmusse authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1985d90 View commit details
    Browse the repository at this point in the history
  165. doc: use correct dash in stability status

    All other stability statuses use `-`, this one uses `–`. This commit
    removes the inconsistency.
    
    PR-URL: #55200
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7c9ceab View commit details
    Browse the repository at this point in the history
  166. doc: mention addons to experimental permission

    PR-URL: #55166
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    RafaelGSS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    286ea4e View commit details
    Browse the repository at this point in the history
  167. test: adding more tests for strip-types

    PR-URL: #54929
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    kevinuehara authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ce67e7b View commit details
    Browse the repository at this point in the history
  168. doc: fix unordered error anchors

    PR-URL: #55242
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8a57550 View commit details
    Browse the repository at this point in the history
  169. src: apply getCallSite optimization

    PR-URL: #55174
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    RafaelGSS authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b1d47d0 View commit details
    Browse the repository at this point in the history
  170. module: add internal type def for flushCompileCache

    PR-URL: #55226
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    JakobJingleheimer authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0412ac8 View commit details
    Browse the repository at this point in the history
  171. worker: throw InvalidStateError in postMessage after close

    This update addresses expected failures for invalid postMessage
    after close in WPT.
    
    PR-URL: #55206
    Reviewed-By: Mattias Buelens <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Nahee-Park authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d65334c View commit details
    Browse the repository at this point in the history
  172. fs: acknowledge signal option in filehandle.createReadStream()

    PR-URL: #55148
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    LiviaMedeiros authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    dbfae3f View commit details
    Browse the repository at this point in the history
  173. doc: update test context.assert

    PR-URL: #55186
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    pmarchini authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7ddbfe8 View commit details
    Browse the repository at this point in the history
  174. build: include .nycrc in coverage workflows

    PR-URL: #55210
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    iwuliz authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f89664d View commit details
    Browse the repository at this point in the history
  175. test: move coverage source map tests to new file

    PR-URL: #55123
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    RedYetiDev authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1b30f7f View commit details
    Browse the repository at this point in the history
  176. doc: tweak onboarding instructions

    Add some additional guidance based on something we missed
    in a recent onboarding step.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #55212
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Abdirahim Musse <[email protected]>
    mhdawson authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    297cb0d View commit details
    Browse the repository at this point in the history
  177. meta: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5

    Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.1 to 7.0.5.
    - [Release notes](https://github.com/peter-evans/create-pull-request/releases)
    - [Commits](peter-evans/create-pull-request@8867c4a...5e91468)
    
    ---
    updated-dependencies:
    - dependency-name: peter-evans/create-pull-request
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #55219
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    dependabot[bot] authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f5b4ae5 View commit details
    Browse the repository at this point in the history
  178. meta: bump actions/setup-node from 4.0.3 to 4.0.4

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.3 to 4.0.4.
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@1e60f62...0a44ba7)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-node
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #55223
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    dependabot[bot] authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    33be199 View commit details
    Browse the repository at this point in the history
  179. meta: bump actions/checkout from 4.1.7 to 4.2.0

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@692973e...d632683)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #55224
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    dependabot[bot] authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0f4269f View commit details
    Browse the repository at this point in the history
  180. tools: bump the eslint group in /tools/eslint with 4 updates

    Bumps the eslint group in /tools/eslint with 4 updates: [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js), [eslint](https://github.com/eslint/eslint), [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) and [globals](https://github.com/sindresorhus/globals).
    
    Updates `@stylistic/eslint-plugin-js` from 2.7.2 to 2.8.0
    - [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
    - [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v2.8.0/packages/eslint-plugin-js)
    
    Updates `eslint` from 9.9.1 to 9.11.1
    - [Release notes](https://github.com/eslint/eslint/releases)
    - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
    - [Commits](eslint/eslint@v9.9.1...v9.11.1)
    
    Updates `eslint-plugin-jsdoc` from 50.2.2 to 50.3.1
    - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
    - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
    - [Commits](gajus/eslint-plugin-jsdoc@v50.2.2...v50.3.1)
    
    Updates `globals` from 15.9.0 to 15.10.0
    - [Release notes](https://github.com/sindresorhus/globals/releases)
    - [Commits](sindresorhus/globals@v15.9.0...v15.10.0)
    
    ---
    updated-dependencies:
    - dependency-name: "@stylistic/eslint-plugin-js"
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: eslint
    - dependency-name: eslint
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: eslint
    - dependency-name: eslint-plugin-jsdoc
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: eslint
    - dependency-name: globals
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: eslint
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #55227
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    dependabot[bot] authored and targos committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c988e7e View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. quic: start adding in the internal quic js api

    While the external API for QUIC is expected to be
    the WebTransport API primarily, this provides the
    internal API for QUIC that aligns with the native
    C++ QUIC components.
    
    PR-URL: #53256
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    jasnell authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    75073c5 View commit details
    Browse the repository at this point in the history
  2. src: make minor tweaks to quic c++ for c++20

    PR-URL: #53256
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    jasnell authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    295c17c View commit details
    Browse the repository at this point in the history
  3. build: fix not valid json in coverage

    PR-URL: #55179
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    jakecastelli authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0d93b1e View commit details
    Browse the repository at this point in the history
  4. deps: upgrade openssl sources to quictls/openssl-3.0.14+quic1

    PR-URL: #54336
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    283927e View commit details
    Browse the repository at this point in the history
  5. deps: update archs files for openssl-3.0.14+quic1

    PR-URL: #54336
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    29e6484 View commit details
    Browse the repository at this point in the history
  6. deps: upgrade openssl sources to quictls/openssl-3.0.15+quic1

    PR-URL: #55184
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    63d51c8 View commit details
    Browse the repository at this point in the history
  7. deps: update archs files for openssl-3.0.15+quic1

    PR-URL: #55184
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    bb9f77d View commit details
    Browse the repository at this point in the history
  8. test: update multiple assert tests to use node:test

    PR-URL: #54585
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    jasnell authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    b36f8c2 View commit details
    Browse the repository at this point in the history
  9. worker: add markAsUncloneable api

    External modules need a way to decorate their objects so that node can
    recognize it as a host object for serialization process. Exposing a way
    for turning off instead of turning on is much safer.
    
    PR-URL: #55234
    Refs: #55178
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    jazelly authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    5fda4a1 View commit details
    Browse the repository at this point in the history
  10. meta: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6

    Bumps [mozilla-actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.5 to 0.0.6.
    - [Release notes](https://github.com/mozilla-actions/sccache-action/releases)
    - [Commits](Mozilla-Actions/sccache-action@89e9040...9e326eb)
    
    ---
    updated-dependencies:
    - dependency-name: mozilla-actions/sccache-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #55225
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    dependabot[bot] authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d7b73bb View commit details
    Browse the repository at this point in the history
  11. doc: fix initial default value of autoSelectFamily

    Specify the initial default value of `autoSelectFamily`
    in description of `net.setDefaultAutoSelectFamily()`
    as specified in description of `net.getDefaultAutoSelectFamily()`.
    
    PR-URL: #55245
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    freego555 authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    8eae0d3 View commit details
    Browse the repository at this point in the history
  12. process: add process.features.typescript

    PR-URL: #54295
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4050f68 View commit details
    Browse the repository at this point in the history
  13. doc: move ERR_NAPI_TSFN_START/STOP_IDLE_LOOP to legacy errors

    PR-URL: #55248
    Refs: #17887
    Refs: #32997
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    aduh95 authored and targos committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    195df65 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. src: handle errors correctly in webstorage

    PR-URL: #54544
    Backport-PR-URL: #54683
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    targos committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    0999949 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. deps: V8: partially cherry-pick 8953e49478

    Very partial cherry-pick of upstream commit v8/v8@8953e49478 that fixes
    a hang that shows up in debug builds because of a buggy sanity check
    when computing relationships between command line flags.
    
    Example of the hang:
    
        #include "v8.h"
        #include "libplatform/libplatform.h"
        int main(void) {
          // works: v8::V8::SetFlagsFromString("--gc-global --noincremental-marking");
          v8::V8::SetFlagsFromString("--gc-global");
          v8::V8::SetFlagsFromString("--noincremental-marking");
          v8::V8::InitializePlatform(v8::platform::NewDefaultPlatform().release());
          v8::V8::Initialize(); // hangs in ComputeFlagListHash when defined(DEBUG)
        }
    
    PR-URL: #55274
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    bnoordhuis authored and targos committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2f65b3f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. deps: V8: backport 0d5d6e71bbb0

    Original commit message:
    
        Remove `--js-promise-withresolvers` runtime flag
    
        Co-authored-by: Antoine du Hamel <[email protected]>
        Bug: 42204122
        Change-Id: I017a0d1ae0f8225513206ffb7806a4250be75d4c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5843972
        Reviewed-by: Igor Sheludko <[email protected]>
        Commit-Queue: Erik Corry <[email protected]>
        Reviewed-by: Shu-yu Guo <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#96215}
    
    Refs: v8/v8@0d5d6e7
    PR-URL: #55115
    Backport-PR-URL: #55260
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    anonrig authored and aduh95 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b533a51 View commit details
    Browse the repository at this point in the history
  2. doc: update require(ESM) history and stability status

    PR-URL: #55199
    Backport-PR-URL: #55263
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    aduh95 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5d41b8a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. deps: upgrade npm to 10.9.0

    PR-URL: #55255
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    npm-cli-bot authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f703652 View commit details
    Browse the repository at this point in the history
  2. sqlite: enable foreign key constraints by default

    For historical reasons and to maintain compatibibility with legacy
    database schemas, SQLite does not enable foreign key constraints by
    default. For new applications, however, this behavior is undesirable.
    Currently, any application that wishes to use foreign keys must use
    
        PRAGMA foreign_keys = ON;
    
    to explicitly enable enforcement of such constraints.
    
    This commit changes the behavior of the SQLite API built into Node.js
    to enable foreign key constraints by default. This behavior can be
    overridden by users to maintain compatibility with legacy database
    schemas.
    
    PR-URL: #54777
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tniessen authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    67f5f46 View commit details
    Browse the repository at this point in the history
  3. sqlite: make sourceSQL and expandedSQL string-valued properties

    Change sourceSQL and expandedSQL from being methods to being
    string-valued properties. These fields
    
    - are conceptually properties (and not actions),
    - are derived deterministically from the current state of the object,
    - require no parameters, and
    - are inexpensive to compute.
    
    Also, following the naming conventions of ECMAScript for new features,
    most function names should usually contain a verb, whereas names of
    (dynamically computed) properties generally should not, so the current
    names also seem more appropriate for properties than for functions.
    
    PR-URL: #54721
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tniessen authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c126543 View commit details
    Browse the repository at this point in the history
  4. crypto: add KeyObject.prototype.toCryptoKey

    PR-URL: #55262
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    panva authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f0b4412 View commit details
    Browse the repository at this point in the history
  5. test_runner: assert entry is a valid object

    PR-URL: #55231
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    geeksilva97 authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0f7e3f0 View commit details
    Browse the repository at this point in the history
  6. test_runner: throw on invalid source map

    PR-URL: #55055
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    RedYetiDev authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    800f7c4 View commit details
    Browse the repository at this point in the history
  7. v8: out of bounds copy

    Fixes: #54573
    
    Co-authored-by: ronag <[email protected]>
    Co-authored-by: ramidzkh <[email protected]>
    PR-URL: #55261
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    2 people authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ea7aaf3 View commit details
    Browse the repository at this point in the history
  8. test: add resource to internal module stat test

    PR-URL: #55157
    Reviewed-By: Yagiz Nizipli <[email protected]>
    RafaelGSS authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1b1104e View commit details
    Browse the repository at this point in the history
  9. build: fix notify-on-review-wanted action

    PR-URL: #55304
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    RafaelGSS authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    77f8a3f View commit details
    Browse the repository at this point in the history
  10. tools: update gyp-next to 0.18.2

    PR-URL: #55160
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    nodejs-github-bot authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6a7d201 View commit details
    Browse the repository at this point in the history
  11. test: make test-loaders-workers-spawned less flaky

    PR-URL: #55172
    Reviewed-By: Joyee Cheung <[email protected]>
    aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    17d2f9d View commit details
    Browse the repository at this point in the history
  12. doc: add onboarding details for ambassador program

    PR-URL: #55284
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    marco-ippolito authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    85b7659 View commit details
    Browse the repository at this point in the history
  13. lib: fix module print timing when specifier includes "

    PR-URL: #55150
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    08b5e6c View commit details
    Browse the repository at this point in the history
  14. tools: enforce errors to not be documented in legacy section

    PR-URL: #55218
    Reviewed-By: Antoine du Hamel <[email protected]>
    RedYetiDev authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d51e5a8 View commit details
    Browse the repository at this point in the history
  15. sqlite: disable DQS misfeature by default

    Double-quoted string (DQS) literals are not allowed by the SQL standard,
    which defines that text enclosed in double quotes is to be interpreted
    as an identifier only and never as a string literal. Nevertheless, for
    historical reasons, SQLite allows double-quoted string literals in some
    cases, which leads to inconsistent behavior and subtle bugs.
    
    This commit changes the behavior of the built-in Node.js API for SQLite
    such that the DQS misfeature is disabled by default. This is recommended
    by the developers of SQLite. Users can explicitly enable DQS for
    compatibility with legacy database schemas if necessary.
    
    PR-URL: #55297
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    tniessen authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    57a9d3f View commit details
    Browse the repository at this point in the history
  16. meta: move one or more collaborators to emeritus

    PR-URL: #55300
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Ulises Gascón <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    nodejs-github-bot authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c9a1bbb View commit details
    Browse the repository at this point in the history
  17. doc: fix events.once() example using AbortSignal

    PR-URL: #55144
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jake Yuesong Li <[email protected]>
    foxxyz authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b03272b View commit details
    Browse the repository at this point in the history
  18. benchmark: rewrite detect-esm-syntax benchmark

    Syntax detection has been unflagged so it's no longer meaningful
    to toggle the detection based on CLI flags. It was also previously
    benchmarking cached module imports which isn't very meaningful
    for subsequent loads. This patch updates the benchmark to toggle
    the detection based on the presence of type field in the package.json,
    and generates fixtures to benchmark fresh module loads.
    
    PR-URL: #55238
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    joyeecheung authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    263526d View commit details
    Browse the repository at this point in the history
  19. doc: add pmarchini to collaborators

    Fixes: #55053
    PR-URL: #55331
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    pmarchini authored and aduh95 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    707e7cc View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Revert "doc: update test context.assert"

    This reverts commit 7ddbfe8.
    
    PR-URL: #55344
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8735888 View commit details
    Browse the repository at this point in the history
  2. doc: fix Markdown linter

    PR-URL: #55344
    Reviewed-By: Jake Yuesong Li <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5ea8aa1 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. module: wrap swc error in ERR_INVALID_TYPESCRIPT_SYNTAX

    PR-URL: #55316
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    marco-ippolito authored and aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6fcac73 View commit details
    Browse the repository at this point in the history
  2. doc: move ERR_INVALID_PERFORMANCE_MARK to legacy errors

    PR-URL: #55247
    Refs: #14680
    Refs: #39297
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d8e42be View commit details
    Browse the repository at this point in the history
  3. doc: add release key for aduh95

    PR-URL: #55349
    Refs: nodejs/Release#999
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1921d7a View commit details
    Browse the repository at this point in the history
  4. test: use more informative errors in test-runner-cli

    PR-URL: #55321
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ff3cc3b View commit details
    Browse the repository at this point in the history
  5. deps: update undici to 6.20.0

    PR-URL: #55329
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    nodejs-github-bot authored and aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    34ca36a View commit details
    Browse the repository at this point in the history
  6. test: fix tests when Amaro is unavailable

    Fix two tests that fail when `node` is configured `--without-amaro`.
    
    PR-URL: #55320
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    richardlau authored and aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3273707 View commit details
    Browse the repository at this point in the history
  7. process: fix process.features.typescript when Amaro is unavailable

    PR-URL: #55323
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0655d3a View commit details
    Browse the repository at this point in the history
  8. benchmark: adjust config for deepEqual object

    This should make easier to read on benchmark/compare
    and when generating graphs
    
    PR-URL: #55254
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    RafaelGSS authored and aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    39c7a9e View commit details
    Browse the repository at this point in the history
  9. process: add process.features.require_module

    For detecting whether `require(esm)` is supported without triggering
    the experimental warning.
    
    PR-URL: #55241
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    joyeecheung authored and aduh95 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e95163b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. 2024-10-16, Version 22.10.0 (Current)

    Notable changes:
    
    crypto:
      * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262
      * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159
    doc:
      * add abmusse to collaborators (Abdirahim Musse) #55086
    http2:
      * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875
    lib:
      * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826
    module:
      * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933
      * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648
      * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971
      * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971
      * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971
    process:
      * (SEMVER-MINOR) add `process.features.require_module` (Joyee Cheung) #55241
      * (SEMVER-MINOR) add `process.features.typescript` (Aviv Keller) #54295
    src:
      * mark `node --run` as stable (Yagiz Nizipli) #53763
    test_runner:
      * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126
      * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851
      * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937
    worker:
      * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234
    
    PR-URL: #55343
    aduh95 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    afe4bc6 View commit details
    Browse the repository at this point in the history