Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: allow ESM that failed to be required to be re-imported #55502

Merged
merged 2 commits into from
Oct 28, 2024
Merged

module: allow ESM that failed to be required to be re-imported #55502

merged 2 commits into from
Oct 28, 2024
+152 −4

Commits on Oct 23, 2024

  1. module: allow ESM that failed to be required to be re-imported 

    When a ESM module cannot be loaded by require due to the presence
of TLA, its module status would be stopped at kInstantiated. In
this case, when it's imported again, we should allow it to be
evaluated asynchronously, as it's also a common pattern for users
to retry with dynamic import when require fails.
    @joyeecheung
    joyeecheung committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bbd4cb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. fixup! module: allow ESM that failed to be required to be re-imported

    @joyeecheung
    joyeecheung committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b0c551c View commit details
    Browse the repository at this point in the history